Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1703059
| From | Paolo Bonzini <pbonzini@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 07/10] KVM: x86: remove not used pvclock_gtod_copy |
| Date | 2017-08-03 14:40 +0200 |
| Message-ID | <uanzY-8o6-7@gated-at.bofh.it> (permalink) |
| References | <ua3hT-2KU-5@gated-at.bofh.it> <ua3hU-2KU-25@gated-at.bofh.it> <uabfs-8iN-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 03/08/2017 01:21, Marcelo Tosatti wrote: >> - if (ka->use_master_clock || >> - (gtod->clock.vclock_mode == VCLOCK_TSC && vcpus_matched)) >> + if (ka->use_master_clock || vcpus_matched) >> kvm_make_request(KVM_REQ_MASTERCLOCK_UPDATE, vcpu); > Don't drop this. The masterclock scheme requires TSC for proper functioning > (or an analysis why its supposed with different HPET+TSC, for example). I think testing gtod->clock.vclock_mode is just an optimization? kvm_get_time_and_clockread would return false anyway and masterclock would not be enabled. Paolo
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4 00/10] make L2's kvm-clock stable, get rid of pvclock_gtod_copy in KVM Denis Plotnikov <dplotnikov@virtuozzo.com> - 2017-08-02 17:00 +0200
[PATCH v4 10/10] kvmclock: implement the extended reading function Denis Plotnikov <dplotnikov@virtuozzo.com> - 2017-08-02 17:00 +0200
[PATCH v4 07/10] KVM: x86: remove not used pvclock_gtod_copy Denis Plotnikov <dplotnikov@virtuozzo.com> - 2017-08-02 17:00 +0200
Re: [PATCH v4 07/10] KVM: x86: remove not used pvclock_gtod_copy Marcelo Tosatti <mtosatti@redhat.com> - 2017-08-03 01:30 +0200
Re: [PATCH v4 07/10] KVM: x86: remove not used pvclock_gtod_copy Paolo Bonzini <pbonzini@redhat.com> - 2017-08-03 14:40 +0200
[PATCH v4 09/10] pvclock: add clocksource change notification on changing of tsc stable bit Denis Plotnikov <dplotnikov@virtuozzo.com> - 2017-08-02 17:00 +0200
Re: [PATCH v4 09/10] pvclock: add clocksource change notification on changing of tsc stable bit Marcelo Tosatti <mtosatti@redhat.com> - 2017-08-03 01:40 +0200
[PATCH v4 06/10] timekeeper: add clocksource change notifier Denis Plotnikov <dplotnikov@virtuozzo.com> - 2017-08-02 17:00 +0200
Re: [PATCH v4 00/10] make L2's kvm-clock stable, get rid of pvclock_gtod_copy in KVM Paolo Bonzini <pbonzini@redhat.com> - 2017-08-02 18:20 +0200
Re: [PATCH v4 00/10] make L2's kvm-clock stable, get rid of pvclock_gtod_copy in KVM John Stultz <john.stultz@linaro.org> - 2017-08-02 18:50 +0200
Re: [PATCH v4 00/10] make L2's kvm-clock stable, get rid of pvclock_gtod_copy in KVM Paolo Bonzini <pbonzini@redhat.com> - 2017-08-02 19:20 +0200
csiph-web