Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1702994

Re: [PATCH RFC 0/2] KVM: x86: generalize guest cpuid helpers

From David Hildenbrand <david@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH RFC 0/2] KVM: x86: generalize guest cpuid helpers
Date 2017-08-03 14:00 +0200
Message-ID <uamXh-7T1-23@gated-at.bofh.it> (permalink)
References <ua8KB-6uU-3@gated-at.bofh.it>
Organization Red Hat GmbH

Show all headers | View raw


On 02.08.2017 22:41, Radim Krčmář wrote:
> This series does the generalization that we've spoken about recently
> Might be a good time to change the function names as well.
> 
> 
> Radim Krčmář (2):
>   KVM: x86: generalize guest_cpuid_has_ helpers
>   KVM: x86: use general helpers for some cpuid manipulation
> 
>  arch/x86/kvm/cpuid.h | 205 ++++++++++++++++++---------------------------------
>  arch/x86/kvm/mmu.c   |   7 +-
>  arch/x86/kvm/mtrr.c  |   2 +-
>  arch/x86/kvm/svm.c   |   7 +-
>  arch/x86/kvm/vmx.c   |  33 ++++-----
>  arch/x86/kvm/x86.c   |  52 ++++++-------
>  6 files changed, 116 insertions(+), 190 deletions(-)
> 

These numbers speak for themselves.

I really like this cleanup!

Had a quick look over the patches, nothing jumped at me.

-- 

Thanks,

David

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH RFC 0/2] KVM: x86: generalize guest cpuid helpers Radim Krčmář <rkrcmar@redhat.com> - 2017-08-02 22:50 +0200
  Re: [PATCH RFC 0/2] KVM: x86: generalize guest cpuid helpers David Hildenbrand <david@redhat.com> - 2017-08-03 14:00 +0200

csiph-web