Re: [PATCH] mmc: sdhci-msm: add static to local functions

From	Adrian Hunter <adrian.hunter@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mmc: sdhci-msm: add static to local functions
Date	2017-08-03 12:40 +0200
Message-ID	<ualHP-770-19@gated-at.bofh.it> (permalink)
References	<u9hGh-686-3@gated-at.bofh.it>
Organization	Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki

Show all headers | View raw

On 31/07/17 15:00, Masahiro Yamada wrote:
> Detected by sparse.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
> 
>  drivers/mmc/host/sdhci-msm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index 9d601dc0d646..f35db061ee4c 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -611,7 +611,7 @@ static void msm_hc_select_hs400(struct sdhci_host *host)
>   * HS400 - divided clock (free running MCLK/2)
>   * All other modes - default (free running MCLK)
>   */
> -void sdhci_msm_hc_select_mode(struct sdhci_host *host)
> +static void sdhci_msm_hc_select_mode(struct sdhci_host *host)
>  {
>  	struct mmc_ios ios = host->mmc->ios;
>  
> @@ -1049,7 +1049,7 @@ static unsigned int sdhci_msm_get_min_clock(struct sdhci_host *host)
>   * instead directly control the GCC clock as per
>   * HW recommendation.
>   **/
> -void __sdhci_msm_set_clock(struct sdhci_host *host, unsigned int clock)
> +static void __sdhci_msm_set_clock(struct sdhci_host *host, unsigned int clock)
>  {
>  	u16 clk;
>  	/*
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] mmc: sdhci-msm: add static to local functions Adrian Hunter <adrian.hunter@intel.com> - 2017-08-03 12:40 +0200

csiph-web