Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1702594

Re: [PATCH] selftests: futex: fix run_tests target

Show all headers | View raw

On Wed, Aug 02, 2017 at 04:31:42PM -0600, Shuah Khan wrote:
> make -C tools/testing/selftests/futex/ run_tests doesn't run the tests.
> Running run_tests target only when $(OUTPUT) is the $(PWD) is incorrect.
> When $(OUTPUT) is empty, run_tests will not run. Fix it.
> 
> Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT")
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>

So this indeed addresses the problem you reported.

I'm curious about why this was changed like it was. I presume to avoid
some issues with relative paths, like the ./run.sh and the "cd
functional" within run.sh.... but I haven't been able to trigger that.

When you say $(OUTPUT) is empty - when does that occur? Because if it
was in fact "" then the change below would attempt to execute /run.sh
... which is surely not what we want.

> ---
>  tools/testing/selftests/futex/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
> index e2fbb890aef9..7c647f619d63 100644
> --- a/tools/testing/selftests/futex/Makefile
> +++ b/tools/testing/selftests/futex/Makefile
> @@ -14,7 +14,7 @@ all:
>  	done
>  
>  override define RUN_TESTS
> -	@if [ `dirname $(OUTPUT)` = $(PWD) ]; then ./run.sh; fi
> +	$(OUTPUT)/run.sh
>  endef
>  
>  override define INSTALL_RULE
> -- 
> 2.11.0
> 
> 

-- 
Darren Hart
VMware Open Source Technology Center

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] selftests: futex: fix run_tests target Shuah Khan <shuahkh@osg.samsung.com> - 2017-08-03 00:40 +0200
  Re: [PATCH] selftests: futex: fix run_tests target Darren Hart <dvhart@infradead.org> - 2017-08-03 03:00 +0200
    Re: [PATCH] selftests: futex: fix run_tests target Shuah Khan <shuahkh@osg.samsung.com> - 2017-08-03 03:10 +0200
      Re: [PATCH] selftests: futex: fix run_tests target Darren Hart <dvhart@infradead.org> - 2017-08-04 18:50 +0200

csiph-web