Re: [PATCH 2/2] arm64: Define PAGE_OFFSET using GENMASK_ULL

Path	csiph.com!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Nick Desaulniers <ndesaulniers@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] arm64: Define PAGE_OFFSET using GENMASK_ULL
Date	Thu, 03 Aug 2017 01:20:02 +0200
Message-ID	<uab5M-8f2-9@gated-at.bofh.it> (permalink)
References	<uaaMq-7QI-5@gated-at.bofh.it> <uaaMq-7QI-17@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=wCo2oN2PGMxCXY/9z+qVloW+CWv6yPfwVVpi4eX513E=; b=LiGsIbBVzemHV6yNgdUS7PYj64TzY3mVft5x9wgJLNg1oS5mJCc8AVZcbMupsXT8sz oE204uN2oDTeArx40RkynnaExKoduE+8Z90LfamUL4O9/WDpo5eT1wjWW7AkKahg8Xrp 4FdkLpN1WxNxevv05fTNFpS9QoobY/Ljly6GD4ulCb+1/vnvHcIAJHjBHeTn2IN3hJIU C62j3Lp7zGI/NR9AtHycgmO1ub5XBLMUyrkuPjbUZ6wYM+J3wmMnPl1IvWF5BrqQgfx+ h+ShP7ZszH9GlsX8e14j2MFS+QxI2bJlfGnT1kRDNTmpALIkJQVKrsVeOTDxamxsnJAb jmYA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=wCo2oN2PGMxCXY/9z+qVloW+CWv6yPfwVVpi4eX513E=; b=c2GYsbOxdQFmaG2TJrmnvs/+6uYG0OIbz6LP1cQ4n+JptKPBPphQWp2x8CkLEdBiII UhhLGVYxlxStq1rWshJKUmUbehLSHbOdJkKc4WMG1cOUuAVkQCTOKrwzr32UjvCIgoQr JzZv0bNLFghGauE+LPVL4ZI9Eci4D6xEKB/k2s0XUBilUe1VyoAB0imfO/ExqfXTm2ZM BbZCY9x8lom50AsnuQVwpxJWIdMLs7rujxuorGektzFPS3gJbsfwo4iNJRcmLAGN3esa Z064wIup0UoB5kFJ9xyEPM+dF/nhOfy3dU07KPvnnTG+M++W0nn71wYalO3syuc4zuCM Rbsg==
X-Gm-Message-State	AIVw112X5Znw/xu7l/K8eHMIfcBZm9wOXL4votSn6Elusg3S1csQ3BIo OXj/c3DZyA7xbP1WixTU8L5mwLysLyzk
X-Received	by 10.200.8.106 with SMTP id x39mr36340970qth.309.1501715593158; Wed, 02 Aug 2017 16:13:13 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset="UTF-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	59
Organization	linux.* mail to news gateway
X-Original-Cc	zijun_hu <zijun_hu@htc.com>, Andrew Morton <akpm@linux-foundation.org>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Mark Rutland <mark.rutland@arm.com>, Laura Abbott <labbott@redhat.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Doug Anderson <dianders@chromium.org>, Greg Hackmann <ghackmann@google.com>
X-Original-Date	Wed, 2 Aug 2017 16:13:12 -0700
X-Original-Message-ID	<CAKwvOdmjTRJd+UB+0WU3umQZ3YYvOhh9tM3sN8HJLz6qpkaQQw@mail.gmail.com>
X-Original-References	<20170802225159.159536-1-mka@chromium.org> <20170802225159.159536-2-mka@chromium.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1702552

Show key headers only | View raw

don't forget to include linux/bitops.h now in memory.h

/usr/local/google/home/ndesaulniers/android/kernel-wahoo/private/msm-google/arch/arm64/kernel/head.S:47:8:
error:
      function-like macro 'GENMASK_ULL' is not defined
#elif (PAGE_OFFSET & 0x1fffff) != 0
       ^
/usr/local/google/home/ndesaulniers/android/kernel-wahoo/private/msm-google/arch/arm64/include/asm/memory.h:52:22:
note:

      expanded from macro 'PAGE_OFFSET'
#define PAGE_OFFSET             GENMASK_ULL(BITS_PER_LONG_LONG - 1, VA_BITS - 1)
                                ^
1 error generated.

On Wed, Aug 2, 2017 at 3:51 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
> As is the definition causes an integer overflow, which is expected,
> however clang raises the following warning:
>
> arch/arm64/kernel/head.S:47:8: warning:
>       integer overflow in preprocessor expression
>   #elif (PAGE_OFFSET & 0x1fffff) != 0
>          ^~~~~~~~~~~
> arch/arm64/include/asm/memory.h:52:46: note:
>       expanded from macro 'PAGE_OFFSET'
>   #define PAGE_OFFSET             (UL(0xffffffffffffffff) << (VA_BITS - 1))
>                                       ~~~~~~~~~~~~~~~~~~  ^  ~~~~~~~~~~~~~
>
> Use GENMASK_ULL() instead of shifting explicitly, the macro takes care
> of avoiding the overflow.
>
> Reported-by: Nick Desaulniers <ndesaulniers@google.com>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
>  arch/arm64/include/asm/memory.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h
> index 32f82723338a..732d4eed8edd 100644
> --- a/arch/arm64/include/asm/memory.h
> +++ b/arch/arm64/include/asm/memory.h
> @@ -65,7 +65,7 @@
>   */
>  #define VA_BITS                        (CONFIG_ARM64_VA_BITS)
>  #define VA_START               (UL(0xffffffffffffffff) << VA_BITS)
> -#define PAGE_OFFSET            (UL(0xffffffffffffffff) << (VA_BITS - 1))
> +#define PAGE_OFFSET            GENMASK_ULL(BITS_PER_LONG_LONG - 1, VA_BITS - 1)
>  #define KIMAGE_VADDR           (MODULES_END)
>  #define MODULES_END            (MODULES_VADDR + MODULES_VSIZE)
>  #define MODULES_VADDR          (VA_START + KASAN_SHADOW_SIZE)
> --
> 2.14.0.rc1.383.gd1ce394fe2-goog
>



-- 
Thanks,
~Nick Desaulniers

Thread

[PATCH 1/2] bitops: Avoid integer overflow warning in GENMASK_ULL Matthias Kaehlcke <mka@chromium.org> - 2017-08-03 01:00 +0200
  [PATCH 2/2] arm64: Define PAGE_OFFSET using GENMASK_ULL Matthias Kaehlcke <mka@chromium.org> - 2017-08-03 01:00 +0200
    Re: [PATCH 2/2] arm64: Define PAGE_OFFSET using GENMASK_ULL Nick Desaulniers <ndesaulniers@google.com> - 2017-08-03 01:20 +0200
      Re: [PATCH 2/2] arm64: Define PAGE_OFFSET using GENMASK_ULL Matthias Kaehlcke <mka@chromium.org> - 2017-08-03 01:50 +0200
    Re: [PATCH 2/2] arm64: Define PAGE_OFFSET using GENMASK_ULL Nick Desaulniers <ndesaulniers@google.com> - 2017-08-03 01:20 +0200
  Re: [PATCH 1/2] bitops: Avoid integer overflow warning in GENMASK_ULL Matthias Kaehlcke <mka@chromium.org> - 2017-08-03 19:10 +0200

csiph-web