Re: [PATCH 2/2] arm64: Define PAGE_OFFSET using GENMASK_ULL

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Nick Desaulniers <ndesaulniers@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] arm64: Define PAGE_OFFSET using GENMASK_ULL
Date	Thu, 03 Aug 2017 01:20:02 +0200
Message-ID	<uab5M-8f2-7@gated-at.bofh.it> (permalink)
References	<uaaMq-7QI-5@gated-at.bofh.it> <uaaMq-7QI-17@gated-at.bofh.it> <uab5M-8f2-9@gated-at.bofh.it>
X-Original-To	Matthias Kaehlcke <mka@chromium.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=MLXSIXbXpUS32vgcPfeUcW8usXzWc37FcOt2foVhjaM=; b=Daz5tguTbwsCyA/qCAwo6GYA8s5QORu44Ke5/7BN5h4qEQBszSelf0caEGwft2KrZD YSeVi8gSEFeYp4QsZGJDCkC2QkwBu4pdPHxNFPeknFvXEoXVLiCy+OZFlWhl+YQA2UOr mkcu4y1xbJSQWZLrIP20xBnWRCU1M1i3Wm6mk25rIkDCIeO435gCoMFmeZR4cB5pVKkn 5ZlrnCzGlBzUSBqSmUP5J1UrmkeMFRt5fmrZu6JiCYvbGRCKoFtPdA5S/GC7+ASLGw0X IBETLtFnZTwvEZlEATiV/Zhu9cYLPFCdVFPVRcWGs8ORYIXQHZoz1GaUn66t6YFNjUjr u4bA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MLXSIXbXpUS32vgcPfeUcW8usXzWc37FcOt2foVhjaM=; b=jBfX8SR5Ssv8GlXXshGmDLOmDzuBNd1lGMpGUw2SpcjVgqco+CW6Rj9rN8JwiNWGGv LTgvPEcpdA54IsxqWbIXakLgz0cgTK2eS5Nf8C60MOWAIpLsgqAEsxY/XvfXJBwq9ErN +AC22qNp7OnUICU12G7ICDrvn2zjLaVFkS/dzO61MqQWVle4J+4tCGgG+Mtd91F/EJCm wIflYBTR9ykiqH1hSY/Z0a9KX9pt5lALTRdwFaaL2nWT0s/X9rD5ui5qLblNxQGqD9z1 ejbyt8sjPON6v4agO6s5N1bbKXaDoWhJnmfgzeHF5jwOkkJgojXNm4Y2oiUdsvIBR5hv Bc4g==
X-Gm-Message-State	AIVw112geKzJWAA/wdOt8hvp2AYS/9IKb3rEExDDRf1vpbh85cJK2axB musQ8SoCsu2+OvnY/HRqhDokqTlDs5s5
X-Received	by 10.237.62.156 with SMTP id n28mr36469176qtf.203.1501715952432; Wed, 02 Aug 2017 16:19:12 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset="UTF-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	73
Organization	linux.* mail to news gateway
X-Original-Cc	zijun_hu <zijun_hu@htc.com>, Andrew Morton <akpm@linux-foundation.org>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Mark Rutland <mark.rutland@arm.com>, Laura Abbott <labbott@redhat.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Doug Anderson <dianders@chromium.org>, Greg Hackmann <ghackmann@google.com>
X-Original-Date	Wed, 2 Aug 2017 16:19:11 -0700
X-Original-Message-ID	<CAKwvOdn3sBibVa=ai2ZPeBdHb=v=0qJ9+HYAFr-umhEzQtwY7w@mail.gmail.com>
X-Original-References	<20170802225159.159536-1-mka@chromium.org> <20170802225159.159536-2-mka@chromium.org> <CAKwvOdmjTRJd+UB+0WU3umQZ3YYvOhh9tM3sN8HJLz6qpkaQQw@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1702551

Show key headers only | View raw

hmm, seems including the definition of GENMASK_ULL causes tons of issues
see definition of UL() macro
defines _AC
token pastes UL on literal when not assembly
so looks like GENMASK_ULL is not ready to be used from assembly

On Wed, Aug 2, 2017 at 4:13 PM, Nick Desaulniers
<ndesaulniers@google.com> wrote:
> don't forget to include linux/bitops.h now in memory.h
>
> /usr/local/google/home/ndesaulniers/android/kernel-wahoo/private/msm-google/arch/arm64/kernel/head.S:47:8:
> error:
>       function-like macro 'GENMASK_ULL' is not defined
> #elif (PAGE_OFFSET & 0x1fffff) != 0
>        ^
> /usr/local/google/home/ndesaulniers/android/kernel-wahoo/private/msm-google/arch/arm64/include/asm/memory.h:52:22:
> note:
>
>       expanded from macro 'PAGE_OFFSET'
> #define PAGE_OFFSET             GENMASK_ULL(BITS_PER_LONG_LONG - 1, VA_BITS - 1)
>                                 ^
> 1 error generated.
>
> On Wed, Aug 2, 2017 at 3:51 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
>> As is the definition causes an integer overflow, which is expected,
>> however clang raises the following warning:
>>
>> arch/arm64/kernel/head.S:47:8: warning:
>>       integer overflow in preprocessor expression
>>   #elif (PAGE_OFFSET & 0x1fffff) != 0
>>          ^~~~~~~~~~~
>> arch/arm64/include/asm/memory.h:52:46: note:
>>       expanded from macro 'PAGE_OFFSET'
>>   #define PAGE_OFFSET             (UL(0xffffffffffffffff) << (VA_BITS - 1))
>>                                       ~~~~~~~~~~~~~~~~~~  ^  ~~~~~~~~~~~~~
>>
>> Use GENMASK_ULL() instead of shifting explicitly, the macro takes care
>> of avoiding the overflow.
>>
>> Reported-by: Nick Desaulniers <ndesaulniers@google.com>
>> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>> ---
>>  arch/arm64/include/asm/memory.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h
>> index 32f82723338a..732d4eed8edd 100644
>> --- a/arch/arm64/include/asm/memory.h
>> +++ b/arch/arm64/include/asm/memory.h
>> @@ -65,7 +65,7 @@
>>   */
>>  #define VA_BITS                        (CONFIG_ARM64_VA_BITS)
>>  #define VA_START               (UL(0xffffffffffffffff) << VA_BITS)
>> -#define PAGE_OFFSET            (UL(0xffffffffffffffff) << (VA_BITS - 1))
>> +#define PAGE_OFFSET            GENMASK_ULL(BITS_PER_LONG_LONG - 1, VA_BITS - 1)
>>  #define KIMAGE_VADDR           (MODULES_END)
>>  #define MODULES_END            (MODULES_VADDR + MODULES_VSIZE)
>>  #define MODULES_VADDR          (VA_START + KASAN_SHADOW_SIZE)
>> --
>> 2.14.0.rc1.383.gd1ce394fe2-goog
>>
>
>
>
> --
> Thanks,
> ~Nick Desaulniers



-- 
Thanks,
~Nick Desaulniers

Thread

[PATCH 1/2] bitops: Avoid integer overflow warning in GENMASK_ULL Matthias Kaehlcke <mka@chromium.org> - 2017-08-03 01:00 +0200
  [PATCH 2/2] arm64: Define PAGE_OFFSET using GENMASK_ULL Matthias Kaehlcke <mka@chromium.org> - 2017-08-03 01:00 +0200
    Re: [PATCH 2/2] arm64: Define PAGE_OFFSET using GENMASK_ULL Nick Desaulniers <ndesaulniers@google.com> - 2017-08-03 01:20 +0200
      Re: [PATCH 2/2] arm64: Define PAGE_OFFSET using GENMASK_ULL Matthias Kaehlcke <mka@chromium.org> - 2017-08-03 01:50 +0200
    Re: [PATCH 2/2] arm64: Define PAGE_OFFSET using GENMASK_ULL Nick Desaulniers <ndesaulniers@google.com> - 2017-08-03 01:20 +0200
  Re: [PATCH 1/2] bitops: Avoid integer overflow warning in GENMASK_ULL Matthias Kaehlcke <mka@chromium.org> - 2017-08-03 19:10 +0200

csiph-web