Re: [PATCH RFC 1/2] KVM: x86: generalize guest_cpuid_has_ helpers

From	Radim Krčmář <rkrcmar@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH RFC 1/2] KVM: x86: generalize guest_cpuid_has_ helpers
Date	2017-08-04 22:50 +0200
Message-ID	<uaRHH-3rS-3@gated-at.bofh.it> (permalink)
References	<ua8KB-6uU-3@gated-at.bofh.it> <ua8KB-6uU-1@gated-at.bofh.it> <uaN1o-rA-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2017-08-04 17:40+0200, Paolo Bonzini:
> Wow, I didn't expect the compiler to be able to inline all of this and
> even do BUILD_BUG_ON()s on array lookups.  Maybe change inline to
> __always_inline just to be safe?
> 
> If anybody complains we can make it just a BUG.

Good point, i386 wanted to have non-inlined guest_cpuid_get_register(),
but I hope that __always_inline is going to be enough for all.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH RFC 1/2] KVM: x86: generalize guest_cpuid_has_ helpers Radim Krčmář <rkrcmar@redhat.com> - 2017-08-02 22:50 +0200
  Re: [PATCH RFC 1/2] KVM: x86: generalize guest_cpuid_has_ helpers David Hildenbrand <david@redhat.com> - 2017-08-04 17:30 +0200
    Re: [PATCH RFC 1/2] KVM: x86: generalize guest_cpuid_has_ helpers Radim Krčmář <rkrcmar@redhat.com> - 2017-08-04 22:50 +0200
  Re: [PATCH RFC 1/2] KVM: x86: generalize guest_cpuid_has_ helpers Paolo Bonzini <pbonzini@redhat.com> - 2017-08-04 17:50 +0200
    Re: [PATCH RFC 1/2] KVM: x86: generalize guest_cpuid_has_ helpers Radim Krčmář <rkrcmar@redhat.com> - 2017-08-04 22:50 +0200

csiph-web