Re: [PATCH] leds: blinkm: constify attribute_group structures.

From	Jacek Anaszewski <jacek.anaszewski@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] leds: blinkm: constify attribute_group structures.
Date	2017-08-04 22:00 +0200
Message-ID	<uaQVj-2UY-9@gated-at.bofh.it> (permalink)
References	<uaEhr-3np-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Arvind,

Thanks for the patch.

On 08/04/2017 08:25 AM, Arvind Yadav wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work with
> const attribute_group. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/leds/leds-blinkm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/leds-blinkm.c b/drivers/leds/leds-blinkm.c
> index 617fe97..d03ed6b 100644
> --- a/drivers/leds/leds-blinkm.c
> +++ b/drivers/leds/leds-blinkm.c
> @@ -298,7 +298,7 @@ static ssize_t store_test(struct device *dev, struct device_attribute *attr,
>  	NULL,
>  };
>  
> -static struct attribute_group blinkm_group = {
> +static const struct attribute_group blinkm_group = {
>  	.name = "blinkm",
>  	.attrs = blinkm_attrs,
>  };
> 

Applied to the for-next branch of linux-leds.git.

-- 
Best regards,
Jacek Anaszewski

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] leds: blinkm: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-04 08:30 +0200
  Re: [PATCH] leds: blinkm: constify attribute_group structures. Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-08-04 22:00 +0200

csiph-web