Re: [PATCH v9 05/13] iommu/amd: Add function copy_dev_tables()

From	Joerg Roedel <jroedel@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v9 05/13] iommu/amd: Add function copy_dev_tables()
Date	2017-08-04 15:00 +0200
Message-ID	<uaKmT-76Y-27@gated-at.bofh.it> (permalink)
References	<u9DGO-3pR-9@gated-at.bofh.it> <u9DQu-3tn-19@gated-at.bofh.it> <uaJAv-6MJ-51@gated-at.bofh.it> <uaK3y-6XA-45@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Aug 04, 2017 at 08:30:39PM +0800, Baoquan He wrote:
> Sorry, I don't get 'this one' meaning, are you suggesting the copy for
> loop should be take out of the iommu for loop? 
> 
> About the temporary copy of the old device-table, you can see in patch
> 7/13, if irq sanity check failed, it return -1. This return could happen
> in the middle of copy. So I think we should do a whole successful copy,
> or don't copy at all. It might not be good do half copy.

No, I mean that you should move the copy of the complete device-table
out of the for_each_iommu() loop. Currently you make sure you copy only
once with the 'copied' flag, but that is not necessary if you move the
code behind the loop.

Thread

[PATCH v9 00/13] Fix the on-flight DMA issue on system with amd iommu Baoquan He <bhe@redhat.com> - 2017-08-01 13:40 +0200
  [PATCH v9 02/13] iommu/amd: add several helper functions Baoquan He <bhe@redhat.com> - 2017-08-01 13:40 +0200
  [PATCH v9 05/13] iommu/amd: Add function copy_dev_tables() Baoquan He <bhe@redhat.com> - 2017-08-01 13:50 +0200
    Re: [PATCH v9 05/13] iommu/amd: Add function copy_dev_tables() Joerg Roedel <jroedel@suse.de> - 2017-08-04 14:10 +0200
      Re: [PATCH v9 05/13] iommu/amd: Add function copy_dev_tables() Baoquan He <bhe@redhat.com> - 2017-08-04 14:30 +0200
      Re: [PATCH v9 05/13] iommu/amd: Add function copy_dev_tables() Baoquan He <bhe@redhat.com> - 2017-08-04 14:40 +0200
        Re: [PATCH v9 05/13] iommu/amd: Add function copy_dev_tables() Joerg Roedel <jroedel@suse.de> - 2017-08-04 15:00 +0200
          Re: [PATCH v9 05/13] iommu/amd: Add function copy_dev_tables() Baoquan He <bhe@redhat.com> - 2017-08-04 15:10 +0200
  [PATCH v9 01/13] iommu/amd: Detect pre enabled translation Baoquan He <bhe@redhat.com> - 2017-08-01 13:50 +0200

csiph-web