Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1703861

Re: [PATCH 2/3] drm/msm/mdp5: mark runtime_pm functions as __maybe_unused

Show all headers | View raw

On 08/03/2017 05:20 PM, Arnd Bergmann wrote:
> When CONFIG_PM is disabled, we get harmless warnings about unused
> functions:
> 
> drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c:1025:12: error: 'mdp5_runtime_resume' defined but not used [-Werror=unused-function]
>   static int mdp5_runtime_resume(struct device *dev)
>              ^~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c:1015:12: error: 'mdp5_runtime_suspend' defined but not used [-Werror=unused-function]
>   static int mdp5_runtime_suspend(struct device *dev)
>              ^~~~~~~~~~~~~~~~~~~~
> 
> This marks both functions as __maybe_unused so the compiler
> can drop them silently.

Thanks for the fix. Since the commit is still in Rob's -next branch,
I'll post a new version which fixes this.

Archit

> 
> Fixes: d68fe15b1878 ("drm/msm/mdp5: Use runtime PM get/put API instead of toggling clocks")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c
> index 9f9d95f7c80f..f7c0698fec40 100644
> --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c
> +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c
> @@ -1012,7 +1012,7 @@ static int mdp5_dev_remove(struct platform_device *pdev)
>   	return 0;
>   }
>   
> -static int mdp5_runtime_suspend(struct device *dev)
> +static __maybe_unused int mdp5_runtime_suspend(struct device *dev)
>   {
>   	struct platform_device *pdev = to_platform_device(dev);
>   	struct mdp5_kms *mdp5_kms = platform_get_drvdata(pdev);
> @@ -1022,7 +1022,7 @@ static int mdp5_runtime_suspend(struct device *dev)
>   	return mdp5_disable(mdp5_kms);
>   }
>   
> -static int mdp5_runtime_resume(struct device *dev)
> +static __maybe_unused int mdp5_runtime_resume(struct device *dev)
>   {
>   	struct platform_device *pdev = to_platform_device(dev);
>   	struct mdp5_kms *mdp5_kms = platform_get_drvdata(pdev);
> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] drm/msm: remove unused variable Arnd Bergmann <arnd@arndb.de> - 2017-08-03 14:00 +0200
  [PATCH 3/3] drm/msm: use %z format modifier for printing size_t Arnd Bergmann <arnd@arndb.de> - 2017-08-03 14:00 +0200
  [PATCH 2/3] drm/msm/mdp5: mark runtime_pm functions as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2017-08-03 14:00 +0200
    Re: [PATCH 2/3] drm/msm/mdp5: mark runtime_pm functions as  __maybe_unused Archit Taneja <architt@codeaurora.org> - 2017-08-04 12:40 +0200

csiph-web