Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1703831

Re: [PATCH] sched/core: Remove unnecessary initialization init_idle_bootup_task()

Show all headers | View raw

On Fri, Aug 04, 2017 at 05:19:37PM +0800, Cheng Jian wrote:
> init_idle_bootup_task( ) is called in rest_init( ) to switch
> the scheduling class of the boot thread to the idle class
> 
> the function only set :
>     idle->sched_class = &idle_sched_class;
> which has been set in init_idle() called by sched_init()
>     /*
>      * The idle tasks have their own, simple scheduling class:
>      */
>     idle->sched_class = &idle_sched_class;
> 
> We've already set the boot thread to idle class in
> start_kernel()->sched_init()->init_idle()
> so it's unnecessary to set it again in
> start_kernel()->rest_init()->init_idle_bootup_task()

Yeah, does look a bit redundant. Thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] sched/core: Remove unnecessary initialization init_idle_bootup_task() Cheng Jian <cj.chengjian@huawei.com> - 2017-08-04 11:20 +0200
  Re: [PATCH] sched/core: Remove unnecessary initialization  init_idle_bootup_task() Peter Zijlstra <peterz@infradead.org> - 2017-08-04 11:50 +0200
  [tip:sched/core] sched/core: Remove unnecessary initialization  init_idle_bootup_task() tip-bot for Cheng Jian <tipbot@zytor.com> - 2017-08-10 14:20 +0200

csiph-web