Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1702437

Re: [PATCH] KVM: svm: support single stepping over emulated instructions

Show all headers | View raw

2017-08-02 18:03+0200, Paolo Bonzini:
> Use kvm_skip_emulated_instruction so that debug exceptions are
> properly injected.  This fixes debug.flat on AMD machines.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---

We already have b742c1e6e79d ("KVM: SVM: handle singlestep exception
when skipping emulated instructions"), so the only applicable part of
this patch is

> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 0e846f0cb83b..931ba449456e 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -5548,6 +5548,7 @@ static void kvm_vcpu_do_singlestep(struct kvm_vcpu *vcpu, int *r)
>  		 */
>  		vcpu->arch.dr6 &= ~15;
>  		vcpu->arch.dr6 |= DR6_BS | DR6_RTM;
> +		kvm_update_dr6(vcpu);
>  		kvm_queue_exception(vcpu, DB_VECTOR);
>  	}
>  }

which makes sense.  And shouldn't we do the same for
kvm_vcpu_check_breakpoint()?

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] KVM: svm: support single stepping over emulated instructions Paolo Bonzini <pbonzini@redhat.com> - 2017-08-02 18:10 +0200
  Re: [PATCH] KVM: svm: support single stepping over emulated  instructions Radim Krčmář <rkrcmar@redhat.com> - 2017-08-02 22:20 +0200
    Re: [PATCH] KVM: svm: support single stepping over emulated  instructions Paolo Bonzini <pbonzini@redhat.com> - 2017-08-03 07:40 +0200

csiph-web