Re: [PATCH v1 03/15] perf, tools, stat: Fix saved values rbtree lookup

From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 03/15] perf, tools, stat: Fix saved values rbtree lookup
Date	2017-08-02 21:20 +0200
Message-ID	<ua7lv-5EM-21@gated-at.bofh.it> (permalink)
References	<u6VgR-3zh-3@gated-at.bofh.it> <u6VgT-3zh-43@gated-at.bofh.it> <u9Wq5-6U6-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Wed, Aug 02, 2017 at 09:35:13AM +0200, Jiri Olsa escreveu:
> On Mon, Jul 24, 2017 at 04:40:03PM -0700, Andi Kleen wrote:
> > From: Andi Kleen <ak@linux.intel.com>
> > 
> > The stat shadow saved values rbtree is indexed by a pointer.
> > Fix the comparison function:
> > 
> > - We cannot return a pointer delta as an int because
> > that loses bits on 64bit.
> > - Doing pointer arithmetic on the struct pointer
> > only works if the objects are spaced by the multiple
> > of the object size, which is not guaranteed for individual
> > malloc'ed object
> > 
> > Replace it with a proper comparison.
> > 
> > This fixes various problems with values not being found.
> > 
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
> 
> Acked-by: Jiri Olsa <jolsa@kernel.org>

Applied.

- Arnaldo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v1 03/15] perf, tools, stat: Fix saved values rbtree  lookup Jiri Olsa <jolsa@redhat.com> - 2017-08-02 09:40 +0200
  Re: [PATCH v1 03/15] perf, tools, stat: Fix saved values rbtree  lookup Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-08-02 21:20 +0200

csiph-web