Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1702373
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC 2/4] cgroup: implement hierarchy limits |
| Date | 2017-08-02 20:50 +0200 |
| Message-ID | <ua6Su-5de-19@gated-at.bofh.it> (permalink) |
| References | <ua6Su-5de-21@gated-at.bofh.it> <ua6Su-5de-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hello, Roman.
Generally looks good to me. One minor nit.
On Wed, Aug 02, 2017 at 05:55:30PM +0100, Roman Gushchin wrote:
> +static ssize_t cgroup_max_descendants_write(struct kernfs_open_file *of,
> + char *buf, size_t nbytes, loff_t off)
> +{
> + struct cgroup *cgrp;
> + int descendants;
> + ssize_t ret;
> +
> + buf = strstrip(buf);
> + if (!strcmp(buf, "max")) {
> + descendants = INT_MAX;
> + } else {
> + ret = kstrtouint(buf, 0, &descendants);
^^^^^^^^^^^
shouldn't this be kstrtoint?
Thanks.
--
tejun
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [RFC 2/4] cgroup: implement hierarchy limits Tejun Heo <tj@kernel.org> - 2017-08-02 20:50 +0200
csiph-web