Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1702306

[PATCH] video: fbdev: add const to bin_attribute structures

Path csiph.com!eternal-september.org!feeder.eternal-september.org!border1.nntp.ams1.giganews.com!nntp.giganews.com!feeds.phibee-telecom.net!news.panservice.it!bofh.it!news.nic.it!robomod
From Bhumika Goyal <bhumirks@gmail.com>
Newsgroups linux.kernel
Subject [PATCH] video: fbdev: add const to bin_attribute structures
Date Wed, 02 Aug 2017 19:20:03 +0200
Message-ID <ua5tp-4lS-53@gated-at.bofh.it> (permalink)
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=fjz+vc+iG+KOJ92i1QprmpWra0XfKrrH4+T1RqIjTf4=; b=ZrRPGTIK9yTn25B6QXId9eVkgZGTrvFFIlBOe9uz4OgG1AFwCRftaXs5Fk84G7tzMd a0fenMZW9VgYDszRYtqp7e39Tnqq5aiI7Ig8EfWXBn5yNtCa9P0sF60K27ugyQMMzWDS fZRyRy6wfaTwEn0CI8cLPhambqB4OYIOTc7CAzQ8EZw6JnIUGp405T6RTjU8ZMTl+71x yEaHrK1zy1H4vA7PcJOun+yT0OF94Lq4U+QR/2Yy2WsVTMdnin7o78GBmOjmsBSKX9y7 SxWK1ppXX51Lx328diNZgKBbY8efuF+ZQbuTebLJAAb5JaNdieMe2rpb5KYWI7aljfdj oflA==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=fjz+vc+iG+KOJ92i1QprmpWra0XfKrrH4+T1RqIjTf4=; b=FEz+oDEnayGX9UWDbdWo/BABntsBClDqDgerLzgXsfIEmqgfJzGXRP8LmFCJWYG8mQ chANpQZglWobpqd7GR0aKpMbFHxGvnYckDVLQs4chTIj1FX/jEu4HOKFFXUvxng+q3WO 0qGCIbwMVkHby8AguP4YXcmBwPaF0ljAtvM6luqo6Rg22A0t6nmRLrL/JjTm/tg5bNBk lKwyYfPga95aLkvYSCp9zJDzVOsr2GL3mIFoMGlYp6BU20XXiBPoOobUZJuR/e8Xs45n j7OIgF/ZfhLtGu2Nqvmg8WWBIdXuFjAgjO2zIxI7cBgNOI79ixcJ0O3W04/VGBjdjABd GfDQ==
X-Gm-Message-State AIVw111sVcvNX9kQjPaWMH7gT0jjRiY0MHTN9G0tkUlEgUFk7HSDNHky Yq3MgcV8H43xXg==
X-Received by 10.84.133.37 with SMTP id 34mr26615208plf.221.1501693804920; Wed, 02 Aug 2017 10:10:04 -0700 (PDT)
X-Mailer git-send-email 1.9.1
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 48
Organization linux.* mail to news gateway
X-Original-Cc Bhumika Goyal <bhumirks@gmail.com>
X-Original-Date Wed, 2 Aug 2017 22:39:55 +0530
X-Original-Message-ID <1501693795-13090-1-git-send-email-bhumirks@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1702306

Show key headers only | View raw


Add const to bin_attribute structures as they are only passed to the
functions sysfs_{remove/create}_bin_file or
device_{remove/create}_bin_file. The corresponding arguments are of
type const, so declare the structures to be const.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 drivers/video/fbdev/aty/radeon_base.c | 4 ++--
 drivers/video/fbdev/udlfb.c           | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c
index dba479e..1e2ec36 100644
--- a/drivers/video/fbdev/aty/radeon_base.c
+++ b/drivers/video/fbdev/aty/radeon_base.c
@@ -2241,7 +2241,7 @@ static ssize_t radeon_show_edid2(struct file *filp, struct kobject *kobj,
 	return radeon_show_one_edid(buf, off, count, rinfo->mon2_EDID);
 }
 
-static struct bin_attribute edid1_attr = {
+static const struct bin_attribute edid1_attr = {
 	.attr   = {
 		.name	= "edid1",
 		.mode	= 0444,
@@ -2250,7 +2250,7 @@ static ssize_t radeon_show_edid2(struct file *filp, struct kobject *kobj,
 	.read	= radeon_show_edid1,
 };
 
-static struct bin_attribute edid2_attr = {
+static const struct bin_attribute edid2_attr = {
 	.attr   = {
 		.name	= "edid2",
 		.mode	= 0444,
diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c
index 05ef657..4454eb4 100644
--- a/drivers/video/fbdev/udlfb.c
+++ b/drivers/video/fbdev/udlfb.c
@@ -1465,7 +1465,7 @@ static ssize_t metrics_reset_store(struct device *fbdev,
 	return count;
 }
 
-static struct bin_attribute edid_attr = {
+static const struct bin_attribute edid_attr = {
 	.attr.name = "edid",
 	.attr.mode = 0666,
 	.size = EDID_LENGTH,
-- 
1.9.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH] video: fbdev: add const to bin_attribute structures Bhumika Goyal <bhumirks@gmail.com> - 2017-08-02 19:20 +0200

csiph-web