Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1702297

[PATCH 9/9] [media] saa7146: hexium_gemini: constify pci_device_id.

Show all headers | View raw

pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <media/drv-intf/saa7146.h>
and <linux/pci.h> work with const pci_device_id. So mark the non-const
structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/media/pci/saa7146/hexium_gemini.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/pci/saa7146/hexium_gemini.c b/drivers/media/pci/saa7146/hexium_gemini.c
index c889ec9..f708cab 100644
--- a/drivers/media/pci/saa7146/hexium_gemini.c
+++ b/drivers/media/pci/saa7146/hexium_gemini.c
@@ -363,7 +363,7 @@ static struct saa7146_pci_extension_data hexium_gemini_dual_4bnc = {
 	.ext = &hexium_extension,
 };
 
-static struct pci_device_id pci_tbl[] = {
+static const struct pci_device_id pci_tbl[] = {
 	{
 	 .vendor = PCI_VENDOR_ID_PHILIPS,
 	 .device = PCI_DEVICE_ID_PHILIPS_SAA7146,
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] constify media pci_device_id/pci_tbl. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-02 19:20 +0200
  [PATCH 7/9] [media] saa7146: mxb: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-02 19:20 +0200
  [PATCH 9/9] [media] saa7146: hexium_gemini: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-02 19:20 +0200
  [PATCH 4/9] [media] ttpci: budget-ci: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-02 19:20 +0200
  [PATCH 6/9] [media] ttpci: av7110: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-02 19:20 +0200
  [PATCH 3/9] [media] ttpci: budget-patch: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-02 19:20 +0200

csiph-web