Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1702197

Re: [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor controller

Show all headers | View raw

Hi Guochun,

Le 02/08/2017 à 10:36, Boris Brezillon a écrit :
> Hi Matthias,
> 
> On Tue, 1 Aug 2017 14:33:22 +0200
> Matthias Brugger <matthias.bgg@gmail.com> wrote:
> 
>> On 07/25/2017 04:10 AM, Guochun Mao wrote:
>>> Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
>>> for nor flash node's compatible strings.
>>>
>>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>>> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
>>> ---
>>>   .../devicetree/bindings/mtd/mtk-quadspi.txt        |    2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
>>> index 5ded66a..9845ff4 100644
>>> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
>>> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
>>> @@ -3,6 +3,8 @@
>>>   Required properties:
>>>   - compatible: 	  The possible values are:
>>>   		  "mediatek,mt2701-nor"
>>> +		  "mediatek,mt2712-nor"
>>> +		  "mediatek,mt7622-nor"
>>>   		  "mediatek,mt7623-nor"
>>>   		  "mediatek,mt8173-nor"
>>>   		  For mt8173, compatible should be "mediatek,mt8173-nor".
>>>

There should be another patch to update the mtk_nor_of_ids[] array in
the mtk-quadspi.c driver, shouldn't it?

Currently, I only see the "mediatek,mt8173-nor" compatible string at the
driver side. The driver and its documentation should be aligned and both
patches should be applied at the same time.

Best regards,

Cyrille

>>
>> Boris, will you take this through your tree, or do you prefer that I take it?
> 
> I'm not the spi-nor maintainer, you should ask Cyrille or Marek.
> 
> Regards,
> 
> Boris
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor  controller Matthias Brugger <matthias.bgg@gmail.com> - 2017-08-01 14:40 +0200
  Re: [PATCH] dt-bindings: mtd: add new compatible strings for mtk  nor controller Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-08-02 10:40 +0200
    Re: [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor  controller Cyrille Pitchen <cyrille.pitchen@wedev4u.fr> - 2017-08-02 17:40 +0200
      Re: [PATCH] dt-bindings: mtd: add new compatible strings for mtk  nor controller Guochun Mao <guochun.mao@mediatek.com> - 2017-08-03 04:20 +0200
        Re: [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor  controller Matthias Brugger <matthias.bgg@gmail.com> - 2017-08-03 12:20 +0200
        Re: [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor  controller Rob Herring <robh@kernel.org> - 2017-08-03 19:50 +0200
          Re: [PATCH] dt-bindings: mtd: add new compatible strings for mtk  nor controller Guochun Mao <guochun.mao@mediatek.com> - 2017-08-04 05:50 +0200

csiph-web