Re: [PATCH] z3fold: use per-cpu unbuddied lists

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	kbuild test robot <lkp@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] z3fold: use per-cpu unbuddied lists
Date	Wed, 02 Aug 2017 16:00:01 +0200
Message-ID	<ua2lP-281-5@gated-at.bofh.it> (permalink)
References	<u9Z4D-aO-43@gated-at.bofh.it>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.41,311,1498546800"; d="gz'50?scan'50,208,50";a="1158225498"
MIME-Version	1.0
Content-Type	multipart/mixed; boundary="TB36FDmn/VVEgNH/"
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
X-Sa-Exim-Connect-IP	<locally generated>
X-Sa-Exim-Mail-From	fengguang.wu@intel.com
X-Sa-Exim-Scanned	No (on bee); SAEximRunCond expanded to false
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	573
Organization	linux.* mail to news gateway
X-Original-Cc	kbuild-all@01.org, Linux-MM <linux-mm@kvack.org>, linux-kernel@vger.kernel.org, Dan Streetman <ddstreet@ieee.org>, Andrew Morton <akpm@linux-foundation.org>, Oleksiy.Avramchenko@sony.com
X-Original-Date	Wed, 2 Aug 2017 21:50:42 +0800
X-Original-Message-ID	<201708022101.VfFg8fxz%fengguang.wu@intel.com>
X-Original-References	<20170802122505.e41d5c778a873375bcb0cc19@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1702131

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Vitaly,

[auto build test ERROR on mmotm/master]
[also build test ERROR on v4.13-rc3 next-20170802]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Vitaly-Wool/z3fold-use-per-cpu-unbuddied-lists/20170802-211153
base:   git://git.cmpxchg.org/linux-mmotm.git master
config: i386-randconfig-x019-201731 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   mm/z3fold.c: In function 'free_pages_work':
>> mm/z3fold.c:310:3: error: implicit declaration of function 'cond_resched' [-Werror=implicit-function-declaration]
      cond_resched();
      ^~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/cond_resched +310 mm/z3fold.c

   292	
   293	static void free_pages_work(struct work_struct *w)
   294	{
   295		struct z3fold_pool *pool = container_of(w, struct z3fold_pool, work);
   296	
   297		spin_lock(&pool->stale_lock);
   298		while (!list_empty(&pool->stale)) {
   299			struct z3fold_header *zhdr = list_first_entry(&pool->stale,
   300							struct z3fold_header, buddy);
   301			struct page *page = virt_to_page(zhdr);
   302	
   303			list_del(&zhdr->buddy);
   304			if (WARN_ON(!test_bit(PAGE_STALE, &page->private)))
   305				continue;
   306			clear_bit(NEEDS_COMPACTING, &page->private);
   307			spin_unlock(&pool->stale_lock);
   308			cancel_work_sync(&zhdr->work);
   309			free_z3fold_page(page);
 > 310			cond_resched();
   311			spin_lock(&pool->stale_lock);
   312		}
   313		spin_unlock(&pool->stale_lock);
   314	}
   315	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Thread

[PATCH] z3fold: use per-cpu unbuddied lists Vitaly Wool <vitalywool@gmail.com> - 2017-08-02 12:30 +0200
  Re: [PATCH] z3fold: use per-cpu unbuddied lists kbuild test robot <lkp@intel.com> - 2017-08-02 16:00 +0200
  Re: [PATCH] z3fold: use per-cpu unbuddied lists Andrew Morton <akpm@linux-foundation.org> - 2017-08-03 01:10 +0200

csiph-web