Groups > linux.kernel > #1702089

Re: [PATCH v3 02/10] cpufreq: provide default frequency-invariance setter function

From	Dietmar Eggemann <dietmar.eggemann@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 02/10] cpufreq: provide default frequency-invariance setter function
Date	2017-08-02 15:00 +0200
Message-ID	<ua1pL-1yS-3@gated-at.bofh.it> (permalink)
References	<u7WNA-1TC-11@gated-at.bofh.it> <u7WNB-1TC-39@gated-at.bofh.it> <u882l-Jq-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Viresh,

On 28/07/17 08:30, Viresh Kumar wrote:
> On 27-07-17, 20:33, Dietmar Eggemann wrote:
>> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
>> index 9bf97a366029..04e2f7e4964e 100644
>> --- a/drivers/cpufreq/cpufreq.c
>> +++ b/drivers/cpufreq/cpufreq.c
>> @@ -2404,6 +2404,17 @@ int cpufreq_boost_enabled(void)
>>  EXPORT_SYMBOL_GPL(cpufreq_boost_enabled);
>>  
>>  /*********************************************************************
>> + *               FREQUENCY INVARIANT ACCOUNTING SUPPORT              *
>> + *********************************************************************/
> 
> We don't need another of these fancy headers :)
> 
> Just add below routine somewhere at the top, maybe before
> cpufreq_generic_init().

Yes, sure. Will address this in the upcoming v4.

Thanks the review!

-- Dietmar

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v3 02/10] cpufreq: provide default frequency-invariance  setter function Dietmar Eggemann <dietmar.eggemann@arm.com> - 2017-08-02 15:00 +0200

csiph-web