Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1702084

Re: [PATCH] staging: vboxvideo: use drm_gem_object_put instead of drm_gem_object_unreference

Show all headers | View raw

On Wed, Aug 2, 2017 at 1:46 AM, Cihangir Akturk <cakturk@gmail.com> wrote:
> drm_gem_object_unreference is a compatibility alias for drm_gem_object_put so should
> not be used by new code.
>
> This patch fixes the following warning reported by coccinelle:
>
> drivers/staging/vboxvideo/vbox_main.c:528:1-27: WARNING: use get/put
> helpers to reference and dereference obj
>
> Signed-off-by: Cihangir Akturk <cakturk@gmail.com>

Care to do this for all the drm drivers, not just the single one in staging?

Hans/Greg: Can we pls fix up MAINTAINERS to make sure vboxdrm patches
also go to dri-devel?

Thanks, Daniel

> ---
>  drivers/staging/vboxvideo/vbox_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vboxvideo/vbox_main.c b/drivers/staging/vboxvideo/vbox_main.c
> index d0c6ec7..1addeac 100644
> --- a/drivers/staging/vboxvideo/vbox_main.c
> +++ b/drivers/staging/vboxvideo/vbox_main.c
> @@ -525,7 +525,7 @@ vbox_dumb_mmap_offset(struct drm_file *file,
>         bo = gem_to_vbox_bo(obj);
>         *offset = vbox_bo_mmap_offset(bo);
>
> -       drm_gem_object_unreference(obj);
> +       drm_gem_object_put(obj);
>         ret = 0;
>
>  out_unlock:
> --
> 2.7.4
>



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] staging: vboxvideo: use drm_gem_object_put instead of drm_gem_object_unreference Daniel Vetter <daniel@ffwll.ch> - 2017-08-02 14:40 +0200
  Re: [PATCH] staging: vboxvideo: use drm_gem_object_put instead of  drm_gem_object_unreference Cihangir Akturk <cakturk@gmail.com> - 2017-08-02 15:50 +0200
    Re: [PATCH] staging: vboxvideo: use drm_gem_object_put instead of drm_gem_object_unreference Daniel Vetter <daniel@ffwll.ch> - 2017-08-02 16:20 +0200

csiph-web