Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1702037
| From | Pavel Machek <pavel@ucw.cz> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH 1/5] dt-bindings: power: Add battery types |
| Date | 2017-08-02 13:50 +0200 |
| Message-ID | <ua0k2-RL-13@gated-at.bofh.it> (permalink) |
| References | <u9MqK-nk-3@gated-at.bofh.it> <u9MqN-nk-93@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
Hi! > Signed-off-by: Marek Belisko <marek.belisko@gmail.com> > --- > include/dt-bindings/power/power.h | 11 +++++++++++ > 1 file changed, 11 insertions(+) > create mode 100644 include/dt-bindings/power/power.h > > diff --git a/include/dt-bindings/power/power.h b/include/dt-bindings/power/power.h > new file mode 100644 > index 0000000..ea36d7f > --- /dev/null > +++ b/include/dt-bindings/power/power.h > @@ -0,0 +1,11 @@ > +#ifndef _DT_BINDINGS_POWER_H > +#define _DT_BINDINGS_POWER_H > + > +#define POWER_SUPPLY_TECHNOLOGY_NiMH 1 > +#define POWER_SUPPLY_TECHNOLOGY_LION 2 > +#define POWER_SUPPLY_TECHNOLOGY_LIPO 3 > +#define POWER_SUPPLY_TECHNOLOGY_LiFe 4 Actually I'd add comments here, such as "/* LiFePO4 */, because otherwise it is a bit ambiguous. > +#define POWER_SUPPLY_TECHNOLOGY_NiCd 5 > +#define POWER_SUPPLY_TECHNOLOGY_LiMn 6 > + > +#endif /* _DT_BINDINGS_POWER_H */ The rest of series is ok, you can add Acked-by: Pavel Machek <pavel@ucw.cz> , but I guess someone would want a little more verbose changelogs. BTW what hardware are you working with? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH 0/5] Add formula for LiIon batteries to compute capacity Marek Belisko <marek.belisko@open-nandra.com> - 2017-08-01 23:00 +0200
[RFC PATCH 1/5] dt-bindings: power: Add battery types Marek Belisko <marek.belisko@open-nandra.com> - 2017-08-01 23:00 +0200
Re: [RFC PATCH 1/5] dt-bindings: power: Add battery types Pavel Machek <pavel@ucw.cz> - 2017-08-02 13:40 +0200
Re: [RFC PATCH 1/5] dt-bindings: power: Add battery types Belisko Marek <marek.belisko@gmail.com> - 2017-08-02 13:50 +0200
Re: [RFC PATCH 1/5] dt-bindings: power: Add battery types Pavel Machek <pavel@ucw.cz> - 2017-08-02 13:50 +0200
[RFC PATCH 4/5] power: Add formula for computing LiIon State of Charge from Voltage Marek Belisko <marek.belisko@open-nandra.com> - 2017-08-01 23:00 +0200
csiph-web