Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1702067

Re: [PATCH] staging: pi433: remove some macros, introduce some inline functions

Show all headers | View raw

On Wed, Aug 02, 2017 at 02:07:37PM +0200, Marcus Wolf wrote:
> Hi Dan,
> 
> I get your point and I understand, that there need to be rules to
> simplify the life for the maintainers...
> 
> But I honestly must confess, that at the moment, I don't have the
> time for doing that. I am into two customer projects, that keep me
> very busy these weeks.
> 
> The only thing, I can offer, is to remove all the lines, dealing 
> with the #ifdef DEBUG and leave the rest, as it is and send it again.
> Then all other changes are related to the move from macro to inline...
> If that helps, please let me know.
> 
> If it needs further fragmentation, it'll take something like half 
> a day / a day. I most probably can spent that day end of August, 
> begin of September the earliest.
> 

One trick that might help is you can just use `git citool` and highlight
all the rmw() lines, add selected lines to the commit, then commit that
as one patch.  Repeat for all five patches.

The kernel process does kind of have a steep learning with redoing
patches...  Sorry about that.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] staging: pi433: remove some macros, introduce some  inline functions Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-02 14:00 +0200
  Re: [PATCH] staging: pi433: remove some macros, introduce some  inline functions Marcus Wolf <marcus.wolf@wolf-entwicklungen.de> - 2017-08-02 14:10 +0200
    Re: [PATCH] staging: pi433: remove some macros, introduce some  inline functions Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-02 14:20 +0200

csiph-web