Re: [PATCH v1] i2c: aspeed: fixed potential null pointer dereference

From	Brendan Higgins <brendanhiggins@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1] i2c: aspeed: fixed potential null pointer dereference
Date	2017-07-31 20:30 +0200
Message-ID	<u9nC2-1cX-3@gated-at.bofh.it> (permalink)
References	<u8oqu-3ee-11@gated-at.bofh.it> <u9fbs-4uw-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jul 31, 2017 at 2:27 AM, Joel Stanley <joel@jms.id.au> wrote:
> On Sat, Jul 29, 2017 at 10:30 AM, Brendan Higgins
> <brendanhiggins@google.com> wrote:
>> Before I skipped null checks when the master is in the STOP state; this
>> fixes that.
>>
>> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
>
> Acked-by: Joel Stanley <joel@jms.id.au>
>
> Out of interest, was this found by code review, or did you hit this in testing?

I am pretty sure we hit it in testing. Unfortunately, we had trouble reproducing
it, but we did see a null pointer dereference.

>
> Cheers,
>
> Joel

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1] i2c: aspeed: fixed potential null pointer dereference Brendan Higgins <brendanhiggins@google.com> - 2017-07-29 03:10 +0200
  Re: [PATCH v1] i2c: aspeed: fixed potential null pointer dereference Joel Stanley <joel@jms.id.au> - 2017-07-31 11:30 +0200
    Re: [PATCH v1] i2c: aspeed: fixed potential null pointer dereference Brendan Higgins <brendanhiggins@google.com> - 2017-07-31 20:30 +0200

csiph-web