Re: [PATCH 1/2] printk: Make CONFIG_PRINTK_TIME an int

From	Prarit Bhargava <prarit@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] printk: Make CONFIG_PRINTK_TIME an int
Date	2017-07-31 19:20 +0200
Message-ID	<u9mwi-Ac-7@gated-at.bofh.it> (permalink)
References	<u76YH-2Fx-15@gated-at.bofh.it> <u76YI-2Fx-39@gated-at.bofh.it> <u77Bn-2Vd-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 07/25/2017 08:55 AM, Luis R. Rodriguez wrote:
> On Tue, Jul 25, 2017 at 08:17:26AM -0400, Prarit Bhargava wrote:
>> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
>> index fc47863f629c..26cf6cadd267 100644
>> --- a/kernel/printk/printk.c
>> +++ b/kernel/printk/printk.c
>> @@ -1202,8 +1202,40 @@ static inline void boot_delay_msec(int level)
>>  }
>>  #endif
>>  
>> -static bool printk_time = IS_ENABLED(CONFIG_PRINTK_TIME);
>> -module_param_named(time, printk_time, bool, S_IRUGO | S_IWUSR);
>> +static int printk_time = CONFIG_PRINTK_TIME;
> 
> You could just use unsigned int but is the reason you went with int to
> enable backward compatibility with the old bool =y or =n?

Yes, I wanted to preserve backwards compatibility.

P.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] printk: allow different timestamps for printk.time Prarit Bhargava <prarit@redhat.com> - 2017-07-25 14:20 +0200
  [PATCH 2/2] printk: Add boottime and real timestamps Prarit Bhargava <prarit@redhat.com> - 2017-07-25 14:20 +0200
    Re: [PATCH 2/2] printk: Add boottime and real timestamps Peter Zijlstra <peterz@infradead.org> - 2017-07-25 15:10 +0200
      Re: [PATCH 2/2] printk: Add boottime and real timestamps Mark Salyzyn <salyzyn@android.com> - 2017-07-26 00:40 +0200
      Re: [PATCH 2/2] printk: Add boottime and real timestamps Prarit Bhargava <prarit@redhat.com> - 2017-07-28 17:10 +0200
        Re: [PATCH 2/2] printk: Add boottime and real timestamps Thomas Gleixner <tglx@linutronix.de> - 2017-07-28 18:30 +0200
    Re: [PATCH 2/2] printk: Add boottime and real timestamps kbuild test robot <lkp@intel.com> - 2017-07-27 05:10 +0200
  Re: [PATCH 1/2] printk: Make CONFIG_PRINTK_TIME an int "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-07-25 15:00 +0200
    Re: [PATCH 1/2] printk: Make CONFIG_PRINTK_TIME an int Prarit Bhargava <prarit@redhat.com> - 2017-07-31 19:20 +0200

csiph-web