Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1699737

Re: [PATCH 2/2] mm: replace TIF_MEMDIE checks by tsk_is_oom_victim

From Michal Hocko <mhocko@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] mm: replace TIF_MEMDIE checks by tsk_is_oom_victim
Date 2017-07-31 08:50 +0200
Message-ID <u9cGC-2SJ-7@gated-at.bofh.it> (permalink)
References <u7N7z-4g8-7@gated-at.bofh.it> <u8vrX-84d-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat 29-07-17 16:33:35, kbuild test robot wrote:
> Hi Michal,
> 
> [auto build test ERROR on cgroup/for-next]
> [also build test ERROR on v4.13-rc2 next-20170728]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Michal-Hocko/mm-oom-do-not-rely-on-TIF_MEMDIE-for-memory-reserves-access/20170728-101955
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-next
> config: i386-randconfig-c0-07291424 (attached as .config)
> compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from include/linux/ioport.h:12:0,
>                     from include/linux/device.h:16,
>                     from include/linux/node.h:17,
>                     from include/linux/cpu.h:16,
>                     from kernel/cgroup/cpuset.c:25:
>    kernel/cgroup/cpuset.c: In function '__cpuset_node_allowed':
> >> include/linux/compiler.h:123:18: error: implicit declaration of function 'tsk_is_oom_victim' [-Werror=implicit-function-declaration]

Thanks for the report. We need this
---
commit 638b5ab1ed275f23b52a71941b66c8966d332cd7
Author: Michal Hocko <mhocko@suse.com>
Date:   Mon Jul 31 08:45:53 2017 +0200

    fold me
    
    - fix implicit declaration of function 'tsk_is_oom_victim' reported by
      0day
    
    Signed-off-by: Michal Hocko <mhocko@suse.com>

diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index 1cc53dff0d94..734ae4fa9775 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -56,6 +56,7 @@
 #include <linux/time64.h>
 #include <linux/backing-dev.h>
 #include <linux/sort.h>
+#include <linux/oom.h>
 
 #include <linux/uaccess.h>
 #include <linux/atomic.h>
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/2] mm, oom: do not grant oom victims full memory reserves access Michal Hocko <mhocko@kernel.org> - 2017-07-27 11:10 +0200
  [PATCH 1/2] mm, oom: do not rely on TIF_MEMDIE for memory reserves access Michal Hocko <mhocko@kernel.org> - 2017-07-27 11:10 +0200
    Re: [PATCH 1/2] mm, oom: do not rely on TIF_MEMDIE for memory reserves access Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-08-01 17:40 +0200
      Re: [PATCH 1/2] mm, oom: do not rely on TIF_MEMDIE for memory  reserves access Michal Hocko <mhocko@kernel.org> - 2017-08-01 19:00 +0200
        Re: [PATCH 1/2] mm, oom: do not rely on TIF_MEMDIE for memory  reserves access Michal Hocko <mhocko@kernel.org> - 2017-08-02 08:20 +0200
        Re: [PATCH 1/2] mm, oom: do not rely on TIF_MEMDIE for memory reserves access Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-08-03 03:50 +0200
          Re: [PATCH 1/2] mm, oom: do not rely on TIF_MEMDIE for memory  reserves access Michal Hocko <mhocko@kernel.org> - 2017-08-03 09:10 +0200
            Re: [PATCH 1/2] mm, oom: do not rely on TIF_MEMDIE for memory reserves access Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-08-03 10:10 +0200
              Re: [PATCH 1/2] mm, oom: do not rely on TIF_MEMDIE for memory  reserves access Michal Hocko <mhocko@kernel.org> - 2017-08-03 10:30 +0200
    [PATCH v2 1/2] mm, oom: do not rely on TIF_MEMDIE for memory  reserves access Michal Hocko <mhocko@kernel.org> - 2017-08-02 10:30 +0200
      Re: [PATCH v2 1/2] mm, oom: do not rely on TIF_MEMDIE for memory  reserves access Mel Gorman <mgorman@techsingularity.net> - 2017-08-03 11:40 +0200
        Re: [PATCH v2 1/2] mm, oom: do not rely on TIF_MEMDIE for memory  reserves access Michal Hocko <mhocko@kernel.org> - 2017-08-03 13:10 +0200
          Re: [PATCH v2 1/2] mm, oom: do not rely on TIF_MEMDIE for memory  reserves access Mel Gorman <mgorman@techsingularity.net> - 2017-08-03 14:30 +0200
  [PATCH 2/2] mm: replace TIF_MEMDIE checks by tsk_is_oom_victim Michal Hocko <mhocko@kernel.org> - 2017-07-27 11:20 +0200
    Re: [PATCH 2/2] mm: replace TIF_MEMDIE checks by tsk_is_oom_victim Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-07-27 16:10 +0200
    Re: [PATCH 2/2] mm: replace TIF_MEMDIE checks by tsk_is_oom_victim Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-07-27 16:10 +0200
      Re: [PATCH 2/2] mm: replace TIF_MEMDIE checks by tsk_is_oom_victim Michal Hocko <mhocko@kernel.org> - 2017-07-27 16:20 +0200
      Re: [PATCH 2/2] mm: replace TIF_MEMDIE checks by tsk_is_oom_victim Michal Hocko <mhocko@kernel.org> - 2017-07-27 16:50 +0200
    Re: [PATCH 2/2] mm: replace TIF_MEMDIE checks by tsk_is_oom_victim Michal Hocko <mhocko@kernel.org> - 2017-07-31 08:50 +0200
  Re: [PATCH 0/2] mm, oom: do not grant oom victims full memory  reserves access Michal Hocko <mhocko@kernel.org> - 2017-08-01 14:20 +0200
    Re: [PATCH 0/2] mm, oom: do not grant oom victims full memory  reserves access Michal Hocko <mhocko@kernel.org> - 2017-08-01 14:30 +0200
      Re: [PATCH 0/2] mm, oom: do not grant oom victims full memory  reserves access Michal Hocko <mhocko@kernel.org> - 2017-08-01 15:00 +0200
  Re: [PATCH 0/2] mm, oom: do not grant oom victims full memory  reserves access Michal Hocko <mhocko@kernel.org> - 2017-08-07 17:00 +0200

csiph-web