Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1699680
| From | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [greybus-dev] [PATCH 10/11] greybus: usb: constify hc_driver structures |
| Date | 2017-07-31 06:30 +0200 |
| Message-ID | <u9av8-1yG-3@gated-at.bofh.it> (permalink) |
| References | <u8kGd-C9-5@gated-at.bofh.it> <u8kGf-C9-33@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 28-07-17, 22:41, Julia Lawall wrote:
> The hc_driver structure is only passed as the first argument to
> usb_create_hcd, which is declared as const. Thus the hc_driver structure
> itself can be const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/staging/greybus/usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/usb.c b/drivers/staging/greybus/usb.c
> index ccadda0..f93a76d 100644
> --- a/drivers/staging/greybus/usb.c
> +++ b/drivers/staging/greybus/usb.c
> @@ -139,7 +139,7 @@ static int hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, u16 wIndex,
> return ret;
> }
>
> -static struct hc_driver usb_gb_hc_driver = {
> +static const struct hc_driver usb_gb_hc_driver = {
> .description = "greybus-hcd",
> .product_desc = "Greybus USB Host Controller",
> .hcd_priv_size = sizeof(struct gb_usb_device),
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/11] constify hc_driver structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-28 23:10 +0200
[PATCH 11/11] c67x00-hcd: constify hc_driver structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-28 23:10 +0200
[PATCH 01/11] isp1362-hcd: constify hc_driver structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-28 23:10 +0200
[PATCH 09/11] USB: whci-hcd: constify hc_driver structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-28 23:10 +0200
[PATCH 06/11] usb: renesas_usbhs: constify hc_driver structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-28 23:10 +0200
RE: [PATCH 06/11] usb: renesas_usbhs: constify hc_driver structures Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> - 2017-07-31 09:10 +0200
[PATCH 03/11] usb: r8a66597-hcd: constify hc_driver structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-28 23:10 +0200
[PATCH 07/11] isp116x-hcd: constify hc_driver structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-28 23:10 +0200
[PATCH 10/11] greybus: usb: constify hc_driver structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-28 23:10 +0200
Re: [greybus-dev] [PATCH 10/11] greybus: usb: constify hc_driver structures Viresh Kumar <viresh.kumar@linaro.org> - 2017-07-31 06:30 +0200
Re: [PATCH 10/11] greybus: usb: constify hc_driver structures Johan Hovold <johan@kernel.org> - 2017-07-31 09:20 +0200
[PATCH 04/11] usb: host/sl811-hcd: constify hc_driver structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-28 23:10 +0200
[PATCH 05/11] usb: host: u132-hcd: constify hc_driver structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-28 23:10 +0200
[PATCH 02/11] usb: host: max3421-hcd: constify hc_driver structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-28 23:20 +0200
csiph-web