Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1699683
| From | Keerthy <j-keerthy@ti.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2] soc: ti: knav: Add a NULL pointer check for kdev in knav_pool_create |
| Date | 2017-07-31 06:40 +0200 |
| Message-ID | <u9aEN-1Ca-7@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
knav_pool_create is an exported function. In the event of a call before knav_queue_probe, we encounter a NULL pointer dereference in the following line. Hence return -EPROBE_DEFER to the caller till the kdev pointer is non-NULL. Signed-off-by: Keerthy <j-keerthy@ti.com> --- Changes in v2: * Fixed returning an int to returning pointer. drivers/soc/ti/knav_qmss_queue.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c index 279e7c5..d91626b 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -745,6 +745,9 @@ void *knav_pool_create(const char *name, bool slot_found; int ret; + if (!kdev) + return ERR_PTR(-EPROBE_DEFER); + if (!kdev->dev) return ERR_PTR(-ENODEV); -- 1.9.1
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH v2] soc: ti: knav: Add a NULL pointer check for kdev in knav_pool_create Keerthy <j-keerthy@ti.com> - 2017-07-31 06:40 +0200 Re: [PATCH v2] soc: ti: knav: Add a NULL pointer check for kdev in knav_pool_create Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2017-07-31 22:10 +0200
csiph-web