Re: [PATCH] arc: arcv2: cache: Explicitly set MSB counterpart of region ops addresses

From	Vineet Gupta <Vineet.Gupta1@synopsys.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] arc: arcv2: cache: Explicitly set MSB counterpart of region ops addresses
Date	2017-08-02 10:30 +0200
Message-ID	<u9Xct-7q1-5@gated-at.bofh.it> (permalink)
References	<u9C81-20u-1@gated-at.bofh.it> <u9SPw-4x2-15@gated-at.bofh.it> <u9WT7-7j8-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/02/2017 01:33 PM, Alexey Brodkin wrote:
>
>>> -	write_aux_reg(ARC_REG_SLC_RGN_END, (paddr + sz + l2_line_sz - 1));
>>> -	write_aux_reg(ARC_REG_SLC_RGN_START, paddr);
>>> +	end = paddr + sz + l2_line_sz - 1;
>>> +	write_aux_reg(ARC_REG_SLC_RGN_END1, upper_32_bits(end));
>>> +	write_aux_reg(ARC_REG_SLC_RGN_END, lower_32_bits(end));
>>> +	write_aux_reg(ARC_REG_SLC_RGN_START1, upper_32_bits(paddr));
>>> +	write_aux_reg(ARC_REG_SLC_RGN_START, lower_32_bits(paddr));
>> Are these registers present even if PAE is not configured in hardware ?
> Apparently no :(
>
> I did test it on AXS103 but just now realized its latest firmware has PAE40.
> Retested on older firmware (still with HS 2.1) without PAE and indeed those
> AUX registers are not implemented:
> ----------------------->8----------------------
> ...
>
> So I'll respin this patch with conditional setup of those regs
> depending on PAE40 presence.

And please also do another patch which converts the existing is_pae40_enabled() 
calls to is_pae40_exists() or somesuch, as apparently these regs needs to be 
cleared if hw has PAE and kernel not using PAE is immaterial.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] arc: arcv2: cache: Explicitly set MSB counterpart of region ops addresses Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-08-01 12:00 +0200
  Re: [PATCH] arc: arcv2: cache: Explicitly set MSB counterpart of  region ops addresses Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2017-08-02 05:50 +0200
    Re: [PATCH] arc: arcv2: cache: Explicitly set MSB counterpart of  region ops addresses Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-08-02 10:10 +0200
      Re: [PATCH] arc: arcv2: cache: Explicitly set MSB counterpart of  region ops addresses Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2017-08-02 10:30 +0200

csiph-web