Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1701743

Re: [PATCH v2 05/25] mtd: nand: qcom: remove redundant chip select compatible string

Show all headers | View raw

On 07/19/2017 05:17 PM, Abhishek Sahu wrote:
> Currently the compatible “qcom,nandcs” is being used for each
> connected NAND device to support for multiple NAND devices in the
> same bus. The same thing can be achieved by looking reg property
> for each sub nodes which contains the chip select number so this
> patch removes the use of “qcom,nandcs” for specifying NAND device
> sub nodes.
> 
> Since there is no user for this driver currently in so
> changing compatible string is safe.

Reviewed-by: Archit Taneja <architt@codeaurora.org>

> 
> Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
> ---
>   drivers/mtd/nand/qcom_nandc.c | 26 ++++++++++++--------------
>   1 file changed, 12 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/mtd/nand/qcom_nandc.c b/drivers/mtd/nand/qcom_nandc.c
> index 8fa2f0c..110a26a 100644
> --- a/drivers/mtd/nand/qcom_nandc.c
> +++ b/drivers/mtd/nand/qcom_nandc.c
> @@ -2129,22 +2129,20 @@ static int qcom_nandc_probe(struct platform_device *pdev)
>   		goto err_setup;
>   
>   	for_each_available_child_of_node(dn, child) {
> -		if (of_device_is_compatible(child, "qcom,nandcs")) {
> -			host = devm_kzalloc(dev, sizeof(*host), GFP_KERNEL);
> -			if (!host) {
> -				of_node_put(child);
> -				ret = -ENOMEM;
> -				goto err_cs_init;
> -			}
> -
> -			ret = qcom_nand_host_init(nandc, host, child);
> -			if (ret) {
> -				devm_kfree(dev, host);
> -				continue;
> -			}
> +		host = devm_kzalloc(dev, sizeof(*host), GFP_KERNEL);
> +		if (!host) {
> +			of_node_put(child);
> +			ret = -ENOMEM;
> +			goto err_cs_init;
> +		}
>   
> -			list_add_tail(&host->node, &nandc->host_list);
> +		ret = qcom_nand_host_init(nandc, host, child);
> +		if (ret) {
> +			devm_kfree(dev, host);
> +			continue;
>   		}
> +
> +		list_add_tail(&host->node, &nandc->host_list);
>   	}
>   
>   	if (list_empty(&nandc->host_list)) {
> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 05/25] mtd: nand: qcom: remove redundant chip select  compatible string Archit Taneja <architt@codeaurora.org> - 2017-08-02 08:00 +0200

csiph-web