Re: [linux-sunxi] [PATCH v3 09/12] ASoC: sun4i-i2s: Add regmap field to set format

From	Chen-Yu Tsai <wens@csie.org>
Newsgroups	linux.kernel
Subject	Re: [linux-sunxi] [PATCH v3 09/12] ASoC: sun4i-i2s: Add regmap field to set format
Date	2017-08-02 05:40 +0200
Message-ID	<u9SFQ-4t7-9@gated-at.bofh.it> (permalink)
References	<u8AKZ-3qk-3@gated-at.bofh.it> <u8AL0-3qk-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Jul 29, 2017 at 10:17 PM,  <codekipper@gmail.com> wrote:
> From: Marcus Cooper <codekipper@gmail.com>
>
> On the newer SoCs the bits to configure the operational mode are

The subject says "format". Which is it? And please be clear what
"mode" or "format" this configures. Is it the DAI controller's
overall mode (PCM/I2S/Left-Justified/Right-Justified/TDM)? or the
PCM mode (linear/u-law/a-law)?

> located in a different register. Add a regmap field so that this
> location can be configured.
>
> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
> ---
>  sound/soc/sunxi/sun4i-i2s.c | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
> index 6d8d2c4a675b..9e060d1b73d5 100644
> --- a/sound/soc/sunxi/sun4i-i2s.c
> +++ b/sound/soc/sunxi/sun4i-i2s.c
> @@ -106,6 +106,7 @@
>   * @field_fmt_set_sr: regmap field to set sample resolution.
>   * @field_fmt_set_bclk_polarity: regmap field to set clk polarity.
>   * @field_fmt_set_lrclk_polarity: regmap field to set frame polarity.
> + * @field_fmt_set_mode: regmap field to set the operational mode.

Drop the "_set_" part.

ChenYu

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [linux-sunxi] [PATCH v3 09/12] ASoC: sun4i-i2s: Add regmap field  to set format Chen-Yu Tsai <wens@csie.org> - 2017-08-02 05:40 +0200

csiph-web