Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1701641

Re: [Patch V2] crypto: x86/sha1 : Fix reads beyond the number of blocks passed

Show all headers | View raw

On Tue, Aug 01, 2017 at 05:38:32PM -0700, Megha Dey wrote:
> It was reported that the sha1 AVX2 function(sha1_transform_avx2) is
> reading ahead beyond its intended data, and causing a crash if the next
> block is beyond page boundary:
> http://marc.info/?l=linux-crypto-vger&m=149373371023377
> 
> This patch makes sure that there is no overflow for any buffer length.
> 
> It passes the tests written by Jan Stancek that revealed this problem:
> https://github.com/jstancek/sha1-avx2-crash
> 
> Jan, can you verify this fix?
> Herbert, can you re-enable sha1-avx2 once Jan has checked it out and
> revert commit b82ce24426a4071da9529d726057e4e642948667 ?

Can you please include the hunk to actually reenable sha1-avx2
in your patch? Thanks!
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[Patch V2] crypto: x86/sha1 : Fix reads beyond the number of blocks passed Megha Dey <megha.dey@linux.intel.com> - 2017-08-02 02:30 +0200
  Re: [Patch V2] crypto: x86/sha1 : Fix reads beyond the number of  blocks passed Herbert Xu <herbert@gondor.apana.org.au> - 2017-08-02 04:40 +0200
  Re: [Patch V2] crypto: x86/sha1 : Fix reads beyond the number of  blocks passed Jan Stancek <jstancek@redhat.com> - 2017-08-02 12:50 +0200
    Re: [Patch V2] crypto: x86/sha1 : Fix reads beyond the number of  blocks passed Tim Chen <tim.c.chen@linux.intel.com> - 2017-08-02 18:10 +0200

csiph-web