Re: [PATCH net-next v2 01/11] net: dsa: PHY device is mandatory for EEE

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Florian Fainelli <f.fainelli@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next v2 01/11] net: dsa: PHY device is mandatory for EEE
Date	Tue, 01 Aug 2017 23:40:03 +0200
Message-ID	<u9N3t-Rr-35@gated-at.bofh.it> (permalink)
References	<u9M7o-g6-13@gated-at.bofh.it> <u9M7p-g6-35@gated-at.bofh.it>
X-Original-To	Vivien Didelot <vivien.didelot@savoirfairelinux.com>, netdev@vger.kernel.org
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+0ZAI+q8NCUyssxft5bidu9CmGtw/7/nk+nENbTcoc4=; b=Z2ANzDmYWE29yCvFd8y795gy19r/LQO+lfxHSLKK0re8ano0JWEcVHLhjcUZ7dsyLd 575EEex19Iui8yBLhZrz0djt2aw9lX9llMB3VqztMFuyjjG0OfGLayARJ4DBPXHd8fmO bkK4ZpkC39x4gdqpOGBeeoc+IUScuBM98T/KLT3FVubBGGeETUlEzgW4Fep0ng++RpDk jr02T0/eHsMxxIjBz+yQHRcmh3YuDzbDJkSsWJSwwvLZd3QUlKqDz1pLOE8BTHrZO51L 6elmDj1Z/NzRA8EO1yOiA7/DEjp5KcxpqjFMx24aI56G9/y8VPtB+5HAYwvjkCCmEg+e xfxA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+0ZAI+q8NCUyssxft5bidu9CmGtw/7/nk+nENbTcoc4=; b=VxXgjABTIh1DyIZsOSxpVPaV/C/Ts7+r0RuC6TJJDfJVyMWpTMO0fbbMoxccPLpjMI MpBFdWzsFtp5P1OHkDXB3AbFiq7fVHLB0sItbdUOuMlUIzN14SMHdvxgNDCG/9M6NoYO QvXZznpnZuA5csZKSTSMRCeS0S75qy2sfXDsC3pOkEh9P6Onp20886HckTk6PV9W4KUE +8VTLewULmv6XHgKJMx7sUlzY15MV0BGulbF4gt2aJpBsQZjiXchNkvB5/d4eMu1Ns01 PiP6Pv6YTmOWMOxtjVi97W71UzaExZZ3a0YH9NclgmUxDmwCe7VT8+DdIU532ttaQghn KGOg==
X-Gm-Message-State	AIVw112WYncyUOEKyqav2NWi+o1EWRdoUnTpBORPxxGIIY1UY7rU9zZf UmmVAmOw2OrqLQ==
X-Received	by 10.55.17.77 with SMTP id b74mr26389897qkh.257.1501623062268; Tue, 01 Aug 2017 14:31:02 -0700 (PDT)
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Language	en-US
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	10
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" <davem@davemloft.net>, Andrew Lunn <andrew@lunn.ch>, John Crispin <john@phrozen.org>
X-Original-Date	Tue, 1 Aug 2017 14:31:00 -0700
X-Original-Message-ID	<1e4a5f28-4673-8eda-96ab-fffa02d4d4e7@gmail.com>
X-Original-References	<20170801203241.22294-1-vivien.didelot@savoirfairelinux.com> <20170801203241.22294-2-vivien.didelot@savoirfairelinux.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1701524

Show key headers only | View raw

On 08/01/2017 01:32 PM, Vivien Didelot wrote:
> The port's PHY and MAC are both implied in EEE. The current code does
> not call the PHY operations if the related device is NULL. Change that
> by returning -ENODEV if there's no PHY device attached to the interface.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Thread

[PATCH net-next v2 00/11] net: dsa: rework EEE support Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-08-01 22:40 +0200
  [PATCH net-next v2 04/11] net: dsa: qca8k: do not cache unneeded EEE fields Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-08-01 22:40 +0200
  [PATCH net-next v2 03/11] net: dsa: qca8k: enable EEE once Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-08-01 22:40 +0200
  [PATCH net-next v2 09/11] net: dsa: remove PHY device argument from .set_eee Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-08-01 22:40 +0200
    Re: [PATCH net-next v2 09/11] net: dsa: remove PHY device argument  from .set_eee Andrew Lunn <andrew@lunn.ch> - 2017-08-01 23:10 +0200
  [PATCH net-next v2 07/11] net: dsa: mv88e6xxx: call phy_init_eee Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-08-01 22:40 +0200
    Re: [PATCH net-next v2 07/11] net: dsa: mv88e6xxx: call phy_init_eee Andrew Lunn <andrew@lunn.ch> - 2017-08-01 23:10 +0200
  [PATCH net-next v2 10/11] net: dsa: mv88e6xxx: remove EEE support Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-08-01 22:40 +0200
    Re: [PATCH net-next v2 10/11] net: dsa: mv88e6xxx: remove EEE support Andrew Lunn <andrew@lunn.ch> - 2017-08-01 23:10 +0200
  [PATCH net-next v2 01/11] net: dsa: PHY device is mandatory for EEE Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-08-01 22:40 +0200
    Re: [PATCH net-next v2 01/11] net: dsa: PHY device is mandatory for  EEE Andrew Lunn <andrew@lunn.ch> - 2017-08-01 23:10 +0200
    Re: [PATCH net-next v2 01/11] net: dsa: PHY device is mandatory for  EEE Florian Fainelli <f.fainelli@gmail.com> - 2017-08-01 23:40 +0200
  [PATCH net-next v2 02/11] net: dsa: qca8k: fix EEE init Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-08-01 22:40 +0200
  [PATCH net-next v2 11/11] net: dsa: rename switch EEE ops Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-08-01 22:40 +0200
    Re: [PATCH net-next v2 11/11] net: dsa: rename switch EEE ops Andrew Lunn <andrew@lunn.ch> - 2017-08-01 23:10 +0200
  [PATCH net-next v2 05/11] net: dsa: qca8k: empty qca8k_get_eee Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-08-01 22:40 +0200
  [PATCH net-next v2 06/11] net: dsa: bcm_sf2: remove unneeded supported flags Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-08-01 22:50 +0200
    Re: [PATCH net-next v2 06/11] net: dsa: bcm_sf2: remove unneeded  supported flags Florian Fainelli <f.fainelli@gmail.com> - 2017-08-01 23:30 +0200
  Re: [PATCH net-next v2 00/11] net: dsa: rework EEE support David Miller <davem@davemloft.net> - 2017-08-02 05:20 +0200

csiph-web