Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1701400
| From | Grygorii Strashko <grygorii.strashko@ti.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] gpio: omap : Add missing clk_unprepare(). |
| Date | 2017-08-01 21:50 +0200 |
| Message-ID | <u9Ll0-8cw-27@gated-at.bofh.it> (permalink) |
| References | <u9za9-8fB-5@gated-at.bofh.it> <u9za9-8fB-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 08/01/2017 01:44 AM, Arvind Yadav wrote:
> omap_gpio_probe() can fail here and we must disable clock.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/gpio/gpio-omap.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index f8c550de..dbf869f 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -1247,6 +1247,8 @@ static int omap_gpio_probe(struct platform_device *pdev)
> if (ret) {
> pm_runtime_put_sync(dev);
> pm_runtime_disable(dev);
> + if (bank->dbck_flag)
> + clk_unprepare(bank->dbck);
> return ret;
> }
>
>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
--
regards,
-grygorii
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/2] gpio: omap : Add missing clk_unprepare(). Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-01 08:50 +0200 Re: [PATCH 2/2] gpio: omap : Add missing clk_unprepare(). Grygorii Strashko <grygorii.strashko@ti.com> - 2017-08-01 21:50 +0200 Re: [PATCH 2/2] gpio: omap : Add missing clk_unprepare(). Linus Walleij <linus.walleij@linaro.org> - 2017-08-07 14:00 +0200
csiph-web