Re: [PATCH v3 06/16] ntb: ensure ntb_mw_get_align() is only called when the link is up

From	Jon Mason <jdmason@kudzu.us>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 06/16] ntb: ensure ntb_mw_get_align() is only called when the link is up
Date	2017-08-01 20:30 +0200
Message-ID	<u9K5z-7tS-17@gated-at.bofh.it> (permalink)
References	<u7f5T-7HQ-13@gated-at.bofh.it> <u7ffC-82I-71@gated-at.bofh.it> <u9JVT-7qE-17@gated-at.bofh.it> <u9JVV-7qE-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Aug 01, 2017 at 12:17:47PM -0600, Logan Gunthorpe wrote:
> Hey,
> 
> On 01/08/17 12:14 PM, Jon Mason wrote:
> > This also looks like a bug fix.  However, given that it is a little more
> > invasive and no one reporting any problems with it, I'm less apt to
> > pull it into the bug-fixes branch without anyone compilaining of a
> > bug (lest I break something in -stable).
> 
> Yes, 6 and 7 change a semantic of that function. I wouldn't call them
> bug fixes. But you can't pull 7 without pulling 6, as 7 would break
> everything unless the change in 6 occurs.

Okay, then I'll hold off on 7 then.  It wasn't clear to me, based on
the patch descriptions, that this was fallout from the previous patch.
Thanks for clearing this up for me.

Thanks,
Jon

> 
> Thanks,
> 
> Logan
> 
> -- 
> You received this message because you are subscribed to the Google Groups "linux-ntb" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-ntb+unsubscribe@googlegroups.com.
> To post to this group, send email to linux-ntb@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/linux-ntb/c4235dc9-90d0-1e68-7c73-c2a5bec83712%40deltatee.com.
> For more options, visit https://groups.google.com/d/optout.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 06/16] ntb: ensure ntb_mw_get_align() is only called  when the link is up Jon Mason <jdmason@kudzu.us> - 2017-08-01 20:20 +0200
  Re: [PATCH v3 06/16] ntb: ensure ntb_mw_get_align() is only called  when the link is up Logan Gunthorpe <logang@deltatee.com> - 2017-08-01 20:20 +0200
    Re: [PATCH v3 06/16] ntb: ensure ntb_mw_get_align() is only called  when the link is up Jon Mason <jdmason@kudzu.us> - 2017-08-01 20:30 +0200

csiph-web