Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1701229

Re: [PATCH net-next] net: bcmgenet: drop COMPILE_TEST dependency

Show all headers | View raw

On 08/01/2017 04:50 AM, Arnd Bergmann wrote:
> The last patch added the dependency on 'OF && HAS_IOMEM' but left
> COMPILE_TEST as an alternative, which kind of defeats the purpose
> of adding the dependency, we still get randconfig build warnings:
> 
> warning: (NET_DSA_BCM_SF2 && BCMGENET) selects MDIO_BCM_UNIMAC which has unmet direct dependencies (NETDEVICES && MDIO_BUS && HAS_IOMEM && OF_MDIO)
> 
> For compile-testing purposes, we don't really need this anyway,
> as CONFIG_OF can be enabled on all architectures, and HAS_IOMEM
> is present on all architectures we do meaningful compile-testing on
> (the exception being arch/um).
> 
> This makes both OF and HAS_IOMEM hard dependencies.
> 
> Fixes: 5af74bb4fcf8 ("net: bcmgenet: Add dependency on HAS_IOMEM && OF")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks!
-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next] net: bcmgenet: drop COMPILE_TEST dependency Arnd Bergmann <arnd@arndb.de> - 2017-08-01 14:00 +0200
  Re: [PATCH net-next] net: bcmgenet: drop COMPILE_TEST dependency Florian Fainelli <f.fainelli@gmail.com> - 2017-08-01 18:40 +0200
  Re: [PATCH net-next] net: bcmgenet: drop COMPILE_TEST dependency David Miller <davem@davemloft.net> - 2017-08-02 19:50 +0200

csiph-web