Re: Possible race condition in oom-killer

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: Possible race condition in oom-killer
Date	2017-08-01 16:50 +0200
Message-ID	<u9GEH-5cQ-17@gated-at.bofh.it> (permalink)
References	(1 earlier) <u8dY6-4rR-23@gated-at.bofh.it> <u8e7O-4Ks-47@gated-at.bofh.it> <u8rHI-5wl-7@gated-at.bofh.it> <u9Ejv-3Ut-11@gated-at.bofh.it> <u9GbE-52o-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue 01-08-17 23:16:13, Tetsuo Handa wrote:
> Michal Hocko wrote:
> >                       Once we merge [1] then the oom victim wouldn't
> > need to get TIF_MEMDIE to access memory reserves.
> > 
> > [1] http://lkml.kernel.org/r/20170727090357.3205-2-mhocko@kernel.org
> 
> False. We are not setting oom_mm to all thread groups (!CLONE_THREAD) sharing
> that mm (CLONE_VM). Thus, one thread from each thread group sharing that mm
> will have to call out_of_memory() in order to set oom_mm, and they will find
> task_will_free_mem() returning false due to MMF_OOM_SKIP already set, and
> after all goes to next OOM victim selection.

Once the patch is merged we can mark_oom_victim all of them as well.
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: Possible race condition in oom-killer Michal Hocko <mhocko@kernel.org> - 2017-08-01 14:20 +0200
  Re: Possible race condition in oom-killer Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-08-01 16:20 +0200
    Re: Possible race condition in oom-killer Michal Hocko <mhocko@kernel.org> - 2017-08-01 16:50 +0200

csiph-web