Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1701035

[PATCH v3 3/3] drm/bridge/synopsys: dsi: explicitly request exclusive reset control

Show all headers | View raw

Based on patch "Convert drivers to explicit reset API" from Philipp Zabel

Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.

No functional changes.

Cc: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Philippe CORNU <philippe.cornu@st.com>
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
index 781340d..4e1f91e 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
@@ -885,15 +885,11 @@ static int dw_mipi_dsi_bridge_attach(struct drm_bridge *bridge)
 	 * Note that the reset was not defined in the initial device tree, so
 	 * we have to be prepared for it not being found.
 	 */
-	apb_rst = devm_reset_control_get(dev, "apb");
+	apb_rst = devm_reset_control_get_optional_exclusive(dev, "apb");
 	if (IS_ERR(apb_rst)) {
 		ret = PTR_ERR(apb_rst);
-		if (ret == -ENOENT) {
-			apb_rst = NULL;
-		} else {
-			dev_err(dev, "Unable to get reset control: %d\n", ret);
-			return ERR_PTR(ret);
-		}
+		dev_err(dev, "Unable to get reset control: %d\n", ret);
+		return ERR_PTR(ret);
 	}
 
 	if (apb_rst) {
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/3] drm/bridge/synopsys: dsi: Various cleanups Philippe CORNU <philippe.cornu@st.com> - 2017-08-01 15:30 +0200
  [PATCH v3 1/3] drm/bridge/synopsys: dsi: Constify funcs structures Philippe CORNU <philippe.cornu@st.com> - 2017-08-01 15:30 +0200
  [PATCH v3 3/3] drm/bridge/synopsys: dsi: explicitly request exclusive reset control Philippe CORNU <philippe.cornu@st.com> - 2017-08-01 15:30 +0200
  [PATCH v3 2/3] drm/bridge/synopsys: dsi: Register list clean up Philippe CORNU <philippe.cornu@st.com> - 2017-08-01 15:30 +0200
  Re: [PATCH v3 0/3] drm/bridge/synopsys: dsi: Various cleanups Philippe CORNU <philippe.cornu@st.com> - 2017-08-01 15:40 +0200

csiph-web