Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1701076

RE: Issue with commit de3ef1eb1cd - PM / core: Drop run_wake flag from struct dev_pm_info [Was: MEI-related WARN_ON() triggered during resume-from-sleep on v4.13-rc2+]

Show all headers | View raw

> 
> Hi,
> 
> On Tue, Aug 1, 2017 at 7:25 AM, Usyskin, Alexander
> <alexander.usyskin@intel.com> wrote:
> > Hi
> >
> > We using pci_dev_run_wake that changed in mentioned patch to decide if
> > to replace usual PM callbacks with domain ones.
> > IIRC, the mei device is not remote wakeable on that platform, so we
> > should set domain callbacks.
> > There was a patch in PM framework that squashes runtime suspend with
> > usual suspend for some devices.
> > May it be that now pci_dev_run_wake returns true form mei and we are
> > not setting domain callbacks?
> > In that case we going through PCI device level PM path and may trigger
> that squash.
> > That will explain lack of mei logs on suspend.
> >
> > Dominik, can you try comment out "if (!pci_dev_run_wake(pdev))"
> > at drivers/misc/mei/pci-me.c (around line 223) to set domain callbacks
> > by force to see if this is indeed the case?
> 
> Why exactly do you need the pci_dev_run_wake(pdev) check?

We need to re-review this code now, but as far as I remember.
On some platforms with NFC connected via MEI, there was no PME enabled,  hence we needed to keep in band irq opened for rx to wake us up.
 
Thanks
Tomas

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Issue with commit de3ef1eb1cd - PM / core: Drop run_wake flag from  struct dev_pm_info [Was: MEI-related WARN_ON() triggered during  resume-from-sleep on v4.13-rc2+] Dominik Brodowski <linux@dominikbrodowski.net> - 2017-08-01 00:20 +0200
  Re: Issue with commit de3ef1eb1cd - PM / core: Drop run_wake flag  from struct dev_pm_info [Was: MEI-related WARN_ON() triggered during  resume-from-sleep on v4.13-rc2+] "Rafael J. Wysocki" <rafael@kernel.org> - 2017-08-01 02:00 +0200
    Re: Issue with commit de3ef1eb1cd - PM / core: Drop run_wake flag  from struct dev_pm_info [Was: MEI-related WARN_ON() triggered during  resume-from-sleep on v4.13-rc2+] "Rafael J. Wysocki" <rafael@kernel.org> - 2017-08-01 02:10 +0200
      RE: Issue with commit de3ef1eb1cd - PM / core: Drop run_wake flag  from struct dev_pm_info [Was: MEI-related WARN_ON() triggered during  resume-from-sleep on v4.13-rc2+] "Usyskin, Alexander" <alexander.usyskin@intel.com> - 2017-08-01 07:30 +0200
        Re: Issue with commit de3ef1eb1cd - PM / core: Drop run_wake flag  from struct dev_pm_info [Was: MEI-related WARN_ON() triggered during  resume-from-sleep on v4.13-rc2+] Dominik Brodowski <linux@dominikbrodowski.net> - 2017-08-01 08:40 +0200
          RE: Issue with commit de3ef1eb1cd - PM / core: Drop run_wake flag  from struct dev_pm_info [Was: MEI-related WARN_ON() triggered during  resume-from-sleep on v4.13-rc2+] "Winkler, Tomas" <tomas.winkler@intel.com> - 2017-08-01 08:50 +0200
        Re: Issue with commit de3ef1eb1cd - PM / core: Drop run_wake flag  from struct dev_pm_info [Was: MEI-related WARN_ON() triggered during  resume-from-sleep on v4.13-rc2+] "Rafael J. Wysocki" <rafael@kernel.org> - 2017-08-01 14:00 +0200
          RE: Issue with commit de3ef1eb1cd - PM / core: Drop run_wake flag  from struct dev_pm_info [Was: MEI-related WARN_ON() triggered during  resume-from-sleep on v4.13-rc2+] "Winkler, Tomas" <tomas.winkler@intel.com> - 2017-08-01 16:00 +0200
            Re: Issue with commit de3ef1eb1cd - PM / core: Drop run_wake flag  from struct dev_pm_info [Was: MEI-related WARN_ON() triggered during  resume-from-sleep on v4.13-rc2+] "Rafael J. Wysocki" <rafael@kernel.org> - 2017-08-01 17:40 +0200

csiph-web