Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1699235
| From | Julia Lawall <Julia.Lawall@lip6.fr> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 04/12] mmc: moxart: constify mmc_host_ops structures |
| Date | 2017-07-29 08:30 +0200 |
| Message-ID | <u8tqa-6KR-21@gated-at.bofh.it> (permalink) |
| References | <u8tq9-6KR-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
The mmc_host_ops structure is only stored in the ops field of an
mmc_host structure, which is declared as const. Thus the mmc_host_ops
structure itself can be const.
Done with the help of Coccinelle.
// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct mmc_host_ops i@p = { ... };
@ok1@
struct mmc_host *mmc;
identifier r.i;
position p;
@@
mmc->ops = &i@p
@bad@
position p != {r.p,ok1.p};
identifier r.i;
struct mmc_host_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct mmc_host_ops i = { ... };
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/mmc/host/moxart-mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/moxart-mmc.c b/drivers/mmc/host/moxart-mmc.c
index d4dc55a..a0670e9 100644
--- a/drivers/mmc/host/moxart-mmc.c
+++ b/drivers/mmc/host/moxart-mmc.c
@@ -546,7 +546,7 @@ static int moxart_get_ro(struct mmc_host *mmc)
return !!(readl(host->base + REG_STATUS) & WRITE_PROT);
}
-static struct mmc_host_ops moxart_ops = {
+static const struct mmc_host_ops moxart_ops = {
.request = moxart_request,
.set_ios = moxart_set_ios,
.get_ro = moxart_get_ro,
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/12] constify mmc_host_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-29 08:30 +0200 [PATCH 11/12] mmc: mediatek: constify mmc_host_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-29 08:30 +0200 [PATCH 04/12] mmc: moxart: constify mmc_host_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-29 08:30 +0200 [PATCH 10/12] mmc: sdricoh_cs: constify mmc_host_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-29 08:30 +0200 [PATCH 08/12] mmc: vub300: constify mmc_host_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-07-29 08:30 +0200 Re: [PATCH 00/12] constify mmc_host_ops structures Ulf Hansson <ulf.hansson@linaro.org> - 2017-07-31 11:00 +0200
csiph-web