Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1699081

Re: [RESEND PATCH 2/6] ipc: mqueue: Replace timespec with timespec64

From Deepa Dinamani <deepa.kernel@gmail.com>
Newsgroups linux.kernel
Subject Re: [RESEND PATCH 2/6] ipc: mqueue: Replace timespec with timespec64
Date 2017-07-28 22:50 +0200
Message-ID <u8kmS-er-31@gated-at.bofh.it> (permalink)
References <u8iEp-7vB-7@gated-at.bofh.it> <u8iEq-7vB-31@gated-at.bofh.it> <u8jTP-8tF-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Jul 28, 2017 at 1:15 PM, Paul Moore <paul@paul-moore.com> wrote:
> On Fri, Jul 28, 2017 at 2:52 PM, Deepa Dinamani <deepa.kernel@gmail.com> wrote:
>> struct timespec is not y2038 safe. Replace
>> all uses of timespec by y2038 safe struct timespec64.
>>
>> Even though timespec is used here to represent timeouts,
>> replace these with timespec64 so that it facilitates
>> in verification by creating a y2038 safe kernel image
>> that is free of timespec.
>>
>> The syscall interfaces themselves are not changed as part
>> of the patch. They will be part of a different series.
>>
>> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
>> Cc: Paul Moore <paul@paul-moore.com>
>> Cc: Richard Guy Briggs <rgb@redhat.com>
>> ---
>>  include/linux/audit.h |  6 +++---
>>  ipc/mqueue.c          | 28 ++++++++++++++--------------
>>  kernel/audit.h        |  2 +-
>>  kernel/auditsc.c      | 12 ++++++------
>>  4 files changed, 24 insertions(+), 24 deletions(-)
>
> Something is wrong here ... I already merged your audit y2038 fixes,
> you can see them in Linus' tree right now.

This is the audit record for ipc mqueue side of things.
The other patch does not touch this:

-Deepa

On Fri, Jul 28, 2017 at 1:15 PM, Paul Moore <paul@paul-moore.com> wrote:
> On Fri, Jul 28, 2017 at 2:52 PM, Deepa Dinamani <deepa.kernel@gmail.com> wrote:
>> struct timespec is not y2038 safe. Replace
>> all uses of timespec by y2038 safe struct timespec64.
>>
>> Even though timespec is used here to represent timeouts,
>> replace these with timespec64 so that it facilitates
>> in verification by creating a y2038 safe kernel image
>> that is free of timespec.
>>
>> The syscall interfaces themselves are not changed as part
>> of the patch. They will be part of a different series.
>>
>> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
>> Cc: Paul Moore <paul@paul-moore.com>
>> Cc: Richard Guy Briggs <rgb@redhat.com>
>> ---
>>  include/linux/audit.h |  6 +++---
>>  ipc/mqueue.c          | 28 ++++++++++++++--------------
>>  kernel/audit.h        |  2 +-
>>  kernel/auditsc.c      | 12 ++++++------
>>  4 files changed, 24 insertions(+), 24 deletions(-)
>
> Something is wrong here ... I already merged your audit y2038 fixes,
> you can see them in Linus' tree right now.
>
> --
> paul moore
> www.paul-moore.com

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RESEND 0/6] Make ipc y2038 safe Deepa Dinamani <deepa.kernel@gmail.com> - 2017-07-28 21:00 +0200
  [RESEND PATCH 5/6] ipc: shm: Make shmid_kernel timestamps y2038 safe Deepa Dinamani <deepa.kernel@gmail.com> - 2017-07-28 21:00 +0200
  [RESEND PATCH 6/6] utimes: Make utimes y2038 safe Deepa Dinamani <deepa.kernel@gmail.com> - 2017-07-28 21:00 +0200
  [RESEND PATCH 4/6] ipc: sem: Make sem_array timestamps y2038 safe Deepa Dinamani <deepa.kernel@gmail.com> - 2017-07-28 21:00 +0200
  [RESEND PATCH 2/6] ipc: mqueue: Replace timespec with timespec64 Deepa Dinamani <deepa.kernel@gmail.com> - 2017-07-28 21:00 +0200
    Re: [RESEND PATCH 2/6] ipc: mqueue: Replace timespec with timespec64 Paul Moore <paul@paul-moore.com> - 2017-07-28 22:20 +0200
      Re: [RESEND PATCH 2/6] ipc: mqueue: Replace timespec with timespec64 Deepa Dinamani <deepa.kernel@gmail.com> - 2017-07-28 22:50 +0200
        Re: [RESEND PATCH 2/6] ipc: mqueue: Replace timespec with timespec64 Paul Moore <paul@paul-moore.com> - 2017-07-28 23:10 +0200
    Re: [RESEND PATCH 2/6] ipc: mqueue: Replace timespec with timespec64 Paul Moore <paul@paul-moore.com> - 2017-07-28 23:10 +0200
      Re: [RESEND PATCH 2/6] ipc: mqueue: Replace timespec with timespec64 Deepa Dinamani <deepa.kernel@gmail.com> - 2017-07-28 23:30 +0200
    Re: [RESEND PATCH 2/6] ipc: mqueue: Replace timespec with timespec64 Richard Guy Briggs <rgb@redhat.com> - 2017-07-29 17:30 +0200

csiph-web