Re: [PATCH V2 3/4] net-next: dsa: fix flow dissection

From	Andrew Lunn <andrew@lunn.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2 3/4] net-next: dsa: fix flow dissection
Date	2017-07-28 23:30 +0200
Message-ID	<u8kZA-Mn-9@gated-at.bofh.it> (permalink)
References	<u5BWW-2C2-27@gated-at.bofh.it> <u5BWW-2C2-25@gated-at.bofh.it> <u7wgq-200-3@gated-at.bofh.it> <u8jqN-82j-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> thanks for the feedback. should I add 2 callbacks for each of the 2
> parameters ?

Hi John

A single callback is better. We don't want to have to peek into the
packet twice to determine two values.

       Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V2 3/4] net-next: dsa: fix flow dissection John Crispin <john@phrozen.org> - 2017-07-21 11:00 +0200
  Re: [PATCH V2 3/4] net-next: dsa: fix flow dissection Andrew Lunn <andrew@lunn.ch> - 2017-07-26 17:20 +0200
    Re: [PATCH V2 3/4] net-next: dsa: fix flow dissection John Crispin <john@phrozen.org> - 2017-07-28 21:50 +0200
      Re: [PATCH V2 3/4] net-next: dsa: fix flow dissection Andrew Lunn <andrew@lunn.ch> - 2017-07-28 23:30 +0200

csiph-web