Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1698898

Re: [PATCH] [RFC] ARM: move __bug_table into .data for XIP_KERNEL

Show all headers | View raw

On Fri, 28 Jul 2017, Arnd Bergmann wrote:

> Matt Hart reports that vf610m4_defconfig kernels grew to 2GB
> xipImage size after the __bug_table change.
> 
> I tried out a few things and found that moving the bug table
> into the .data section avoids this problem. However, the
> linker script magic is beyond my capabilities here, so this
> is almost certainly not correct.

Well, before your patch the BUG_TABLE location as well as its runtime 
functionality were completely wrong and broken.

> I've added a few people to Cc that understand this better
> than I do, hopefully someone can turn my bogus patch into
> a proper one.

Your patch isn't as bad as you make it, but maybe the following will 
avoid open recoding BUG_TABLE locally:

diff --git a/arch/arm/kernel/vmlinux-xip.lds.S b/arch/arm/kernel/vmlinux-xip.lds.S
index 8265b11621..21b4b29c2f 100644
--- a/arch/arm/kernel/vmlinux-xip.lds.S
+++ b/arch/arm/kernel/vmlinux-xip.lds.S
@@ -237,13 +237,13 @@ SECTIONS
 		 */
 		DATA_DATA
 		CONSTRUCTORS
-
-		_edata = .;
 	}
-	_edata_loc = __data_loc + SIZEOF(.data);
 
 	BUG_TABLE
 
+	_edata = .;
+	_edata_loc = __data_loc + SIZEOF(.data);
+
 #ifdef CONFIG_HAVE_TCM
         /*
 	 * We align everything to a page boundary so we can


Nicolas

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] [RFC] ARM: move __bug_table into .data for XIP_KERNEL Arnd Bergmann <arnd@arndb.de> - 2017-07-28 16:20 +0200
  Re: [PATCH] [RFC] ARM: move __bug_table into .data for XIP_KERNEL Nicolas Pitre <nicolas.pitre@linaro.org> - 2017-07-28 17:30 +0200
    Re: [PATCH] [RFC] ARM: move __bug_table into .data for XIP_KERNEL Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-07-29 01:10 +0200
      Re: [PATCH] [RFC] ARM: move __bug_table into .data for XIP_KERNEL Nicolas Pitre <nicolas.pitre@linaro.org> - 2017-07-29 02:00 +0200

csiph-web