Re: [PATCH] drivers:staging:wlan-ng Correct multiple line dereference

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drivers:staging:wlan-ng Correct multiple line dereference
Date	Fri, 28 Jul 2017 12:30:02 +0200
Message-ID	<u8aGS-2tk-13@gated-at.bofh.it> (permalink)
References	<u8anw-2mH-17@gated-at.bofh.it>
X-Original-To	janani-sankarababu <jananis37@gmail.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	NeoMutt/20170113 (1.7.2)
X-Source-IP	userv0022.oracle.com [156.151.31.74]
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	57
Organization	linux.* mail to news gateway
X-Original-Cc	gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, adrien.descamps@gmail.com, sergio.paracuellos@gmail.com, davem@davemloft.net
X-Original-Date	Fri, 28 Jul 2017 13:29:16 +0300
X-Original-Message-ID	<20170728102916.clog3m3lajfebuju@mwanda>
X-Original-References	<1501236207-27677-1-git-send-email-jananis37@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1698673

Show key headers only | View raw

Fix your email From header to match your Signed-off-by line.  The
subject should be:

[PATCH] staging: wlan-ng: Correct multiple line dereference

On Fri, Jul 28, 2017 at 03:33:27PM +0530, janani-sankarababu wrote:
> This patch fixes multiple line dereference Warning reported by checkpath script. This has been made to simplify the code and make it more readable.

Break this line up at the 70 character mark.

> 
> Signed-off-by: Janani S <jananis37@gmail.com>

Use your full legal name as if you were signing a legal document to
certify that you haven't stolen this code from Darl McBride.

> ---
>  drivers/staging/wlan-ng/hfa384x_usb.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
> index ee5fa86..2fc5f3e 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -1345,15 +1345,13 @@ static int hfa384x_usbctlx_complete_sync(struct hfa384x *hw,
>  		kfree(ctlx);
>  	} else if (mode == DOWAIT) {
>  		struct usbctlx_cmd_completor completor;
> +		struct usbctlx_completor *cmplt;
> +
> +		cmplt = init_cmd_completor(&completor, &ctlx->inbuf.cmdresp,
> +					   &cmd->result);
> 
> 		result =
> -		    hfa384x_usbctlx_complete_sync(hw, ctlx,
> -						  init_cmd_completor(&completor,
> -								     &ctlx->
> -								     inbuf.
> -								     cmdresp,
> -								     &cmd->
> -								     result));
> +		    hfa384x_usbctlx_complete_sync(hw, ctlx, cmplt);


Move this to the previous line:

		result = hfa384x_usbctlx_complete_sync(hw, ctlx, cmplt);

Also the patch got corrupted by your email client so it can't apply.

Read Documentation/process/email-clients.rst

But generally this is a nice little cleanup.  Please resend a v2
version.

regards,
dan carpenter

Thread

[PATCH] drivers:staging:wlan-ng Correct multiple line dereference janani-sankarababu <jananis37@gmail.com> - 2017-07-28 12:10 +0200
  Re: [PATCH] drivers:staging:wlan-ng Correct multiple line dereference Dan Carpenter <dan.carpenter@oracle.com> - 2017-07-28 12:30 +0200
  Re: [PATCH] drivers:staging:wlan-ng Correct multiple line  dereference Joe Perches <joe@perches.com> - 2017-07-28 12:40 +0200

csiph-web