Re: [PATCH 3/3] rtc: sun6i: Remove unneeded initalization of ret in sun6i_rtc_setalarm()

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] rtc: sun6i: Remove unneeded initalization of ret in sun6i_rtc_setalarm()
Date	2017-07-30 16:50 +0200
Message-ID	<u8XHA-1zE-11@gated-at.bofh.it> (permalink)
References	<u2nGO-7sP-11@gated-at.bofh.it> <u2nGO-7sP-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 12/07/2017 at 11:59:50 +0100, Alexey Klimov wrote:
> Signed-off-by: Alexey Klimov <alexey.klimov@arm.com>
> ---
>  drivers/rtc/rtc-sun6i.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c
> index 77bc4d3..1886b85 100644
> --- a/drivers/rtc/rtc-sun6i.c
> +++ b/drivers/rtc/rtc-sun6i.c
> @@ -362,7 +362,7 @@ static int sun6i_rtc_setalarm(struct device *dev, struct rtc_wkalrm *wkalrm)
>  	unsigned long time_now = 0;
>  	unsigned long time_set = 0;
>  	unsigned long time_gap = 0;
> -	int ret = 0;
> +	int ret;
>  

I don't see any reason that would justify that change.

>  	ret = sun6i_rtc_gettime(dev, &tm_now);
>  	if (ret < 0) {
> -- 
> 1.9.1
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 3/3] rtc: sun6i: Remove unneeded initalization of ret in  sun6i_rtc_setalarm() Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-07-30 16:50 +0200

csiph-web