Re: [PATCH 2/4] iio: trigger: stm32-timer: fix write_raw return value

From	Jonathan Cameron <jic23@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/4] iio: trigger: stm32-timer: fix write_raw return value
Date	2017-07-30 15:50 +0200
Message-ID	<u8WLw-XC-19@gated-at.bofh.it> (permalink)
References	<u7TPI-8oO-7@gated-at.bofh.it> <u7TPI-8oO-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 27 Jul 2017 18:18:58 +0200
Fabrice Gasnier <fabrice.gasnier@st.com> wrote:

> Fixes: 4adec7da0536 ("iio: stm32 trigger: Add quadrature encoder device")
> 
> IIO core expects zero as return value for write_raw() callback
> in case of success.
> 
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Applied to the fixes-togreg branch of iio.git.

Thanks

Jonathan
> ---
>  drivers/iio/trigger/stm32-timer-trigger.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/trigger/stm32-timer-trigger.c b/drivers/iio/trigger/stm32-timer-trigger.c
> index 6aa73d6..107918b 100644
> --- a/drivers/iio/trigger/stm32-timer-trigger.c
> +++ b/drivers/iio/trigger/stm32-timer-trigger.c
> @@ -406,9 +406,8 @@ static int stm32_counter_write_raw(struct iio_dev *indio_dev,
>  
>  	switch (mask) {
>  	case IIO_CHAN_INFO_RAW:
> -		regmap_write(priv->regmap, TIM_CNT, val);
> +		return regmap_write(priv->regmap, TIM_CNT, val);
>  
> -		return IIO_VAL_INT;
>  	case IIO_CHAN_INFO_SCALE:
>  		/* fixed scale */
>  		return -EINVAL;

Thread

[PATCH 0/4] iio: trigger: stm32-timer fixes Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-07-27 18:30 +0200
  [PATCH 1/4] iio: trigger: stm32-timer: fix quadrature mode get routine Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-07-27 18:30 +0200
    Re: [PATCH 1/4] iio: trigger: stm32-timer: fix quadrature mode get  routine Jonathan Cameron <jic23@kernel.org> - 2017-07-30 15:50 +0200
  [PATCH 3/4] iio: trigger: stm32-timer: fix get/set down count direction Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-07-27 18:30 +0200
    Re: [PATCH 3/4] iio: trigger: stm32-timer: fix get/set down count  direction Jonathan Cameron <jic23@kernel.org> - 2017-07-30 15:50 +0200
  [PATCH 2/4] iio: trigger: stm32-timer: fix write_raw return value Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-07-27 18:30 +0200
    Re: [PATCH 2/4] iio: trigger: stm32-timer: fix write_raw return  value Jonathan Cameron <jic23@kernel.org> - 2017-07-30 15:50 +0200
  [PATCH 4/4] iio: trigger: stm32-timer: add enable attribute Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-07-27 18:30 +0200
    Re: [PATCH 4/4] iio: trigger: stm32-timer: add enable attribute Jonathan Cameron <jic23@kernel.org> - 2017-07-30 15:50 +0200
  Re: [PATCH 0/4] iio: trigger: stm32-timer fixes Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-07-28 10:20 +0200

csiph-web