Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1699459

[PATCH 22/29] scsi: pmcraid: constify pci_device_id.

Path csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From Arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 22/29] scsi: pmcraid: constify pci_device_id.
Date Sun, 30 Jul 2017 10:50:03 +0200
Message-ID <u8S5d-6pl-35@gated-at.bofh.it> (permalink)
References <u8S5c-6pl-7@gated-at.bofh.it>
X-Original-To martin.petersen@oracle.com, jejb@linux.vnet.ibm.com, mdr@sgi.com, hare@suse.com, aacraid@adaptec.com, matthew@wil.cx, fthain@telegraphics.com.au, schmitzmic@gmail.com, kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, gotom@debian.or.jp, mrochs@linux.vnet.ibm.com, QLogic-Storage-Upstream@cavium.com, jinpu.wang@profitbricks.com
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=G2biHFhH1fb3FQS/D6frLVCLPKC6QwemYE0jbsp9mzU=; b=dB/W4esQA9hWkK3+kXOL2ApjOYBXHgYMJqtTv9VUUeV8q7uAcj1uS9sAG2SbMxPmuI dT9lcp5oo72Ob0ou+BqXgRad+iDUOcjOQqJOMjmDuIAC0r6a9oabfs8eNwrmJaxE991N oL0sgbLY0hMfWgbo5cjJvqATp/6MZOJzYcKvzNp1rkY2RTZ372Pvzl7zte/8Fq/IRV2y rYDphzubt0K1qZYbUhAS4Yo1koMNFIb90wkPGcmQQEv0lxWZkVoz1mUQaa7BFdvgsoM3 0O71ZWKjmZNBIXvHhiuNq1OHc3QymX+tgrB0HPYEbqwpeXtTMbGip85mmmPLBFLSlLH9 GUIA==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=G2biHFhH1fb3FQS/D6frLVCLPKC6QwemYE0jbsp9mzU=; b=AkKOKVmZAw+VNwE7pdFOkCY3JJ8mCHe7WPg61lwqXOD7WAWgKLZJP/pats8AcWy3X/ 7qkxB1cgFu2qitVp8qnam0X8Nic33l+EUAGYsgrbf04V+6ygYdDNqUrdJndwQSsKLxg3 LQ2ckcEUTfA+LvR5DU2agJB4GM32XVTolrSKiIfI3GasHt38iwYzfFGpBXB3i8F62IoG AUY/4NYy3UWM0bmc7RtnZYlWd7FjipHIG60l3Mc44vh3kNPfTvJ+56RO//ifac7+lzNb 0wNteHK6GDmHlaVTOcH5efMAM9l9wnvJS1rVH6fYXX9DBiCpwS35XfQL58ooZIEBPzcr GqtQ==
X-Gm-Message-State AIVw112vTA76wyY0QfwD3RRE9x0lpq5P7pRNSY1KXOwT/9YmNizAkn7e 2Z/los7DA65p0Q==
X-Received by 10.101.75.131 with SMTP id t3mr11899936pgq.387.1501404255636; Sun, 30 Jul 2017 01:44:15 -0700 (PDT)
X-Mailer git-send-email 2.7.4
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 24
Organization linux.* mail to news gateway
X-Original-Cc linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Sun, 30 Jul 2017 14:13:48 +0530
X-Original-Message-ID <1501404235-9105-2-git-send-email-arvind.yadav.cs@gmail.com>
X-Original-References <1501404235-9105-1-git-send-email-arvind.yadav.cs@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1699459

Show key headers only | View raw


pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/scsi/pmcraid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index 1cc814f..1a9e153 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -126,7 +126,7 @@ static struct pmcraid_chip_details pmcraid_chip_cfg[] = {
 /*
  * PCI device ids supported by pmcraid driver
  */
-static struct pci_device_id pmcraid_pci_table[] = {
+static const struct pci_device_id pmcraid_pci_table[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_PMC, PCI_DEVICE_ID_PMC_MAXRAID),
 	  0, 0, (kernel_ulong_t)&pmcraid_chip_cfg[0]
 	},
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 21/29] scsi: nsp32: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-30 10:50 +0200
  [PATCH 26/29] scsi: a100u2w: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-30 10:50 +0200
  [PATCH 29/29] scsi: 3w-xxxx: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-30 10:50 +0200
  [PATCH 22/29] scsi: pmcraid: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-30 10:50 +0200
  [PATCH 25/29] scsi: megaraid: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-30 10:50 +0200
  [PATCH 27/29] scsi: advansys: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-30 10:50 +0200

csiph-web