Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1698609

Re: [PATCH v8 13/13] iommu/amd: Disable iommu only if amd_iommu=off is specified

Show all headers | View raw

On 07/27/17 at 05:58pm, Joerg Roedel wrote:
> On Fri, Jul 21, 2017 at 04:59:11PM +0800, Baoquan He wrote:
> > From: root <root@amd-dinar-02.lab.bos.redhat.com>
> 
> You probaly need to reset the author on this one.

Oops, sorry. I made this patch on a testing machine. Will correct it.

Thanks a lot for all these comments and great suggestions.

> 
> > 
> > It's ok to disable iommu in normal kernel. While there's no need
> > to disable it in kdump kernel after the on-flight dma issue has
> > heen fixed.
> > 
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> > ---
> >  drivers/iommu/amd_iommu_init.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
> > index 8b4bac978062..880f693c809b 100644
> > --- a/drivers/iommu/amd_iommu_init.c
> > +++ b/drivers/iommu/amd_iommu_init.c
> > @@ -2494,7 +2494,8 @@ static int __init early_amd_iommu_init(void)
> >  		goto out;
> >  
> >  	/* Disable any previously enabled IOMMUs */
> > -	disable_iommus();
> > +	if (amd_iommu_disabled)
> > +		disable_iommus();
> >  
> >  	if (amd_iommu_irq_remap)
> >  		amd_iommu_irq_remap = check_ioapic_information();
> > -- 
> > 2.5.5

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v8 00/13] Fix the on-flight DMA issue on system with amd iommu Baoquan He <bhe@redhat.com> - 2017-07-21 11:00 +0200
  [PATCH v8 05/13] iommu/amd: Add function copy_dev_tables() Baoquan He <bhe@redhat.com> - 2017-07-21 11:00 +0200
    Re: [PATCH v8 05/13] iommu/amd: Add function copy_dev_tables() Joerg Roedel <jroedel@suse.de> - 2017-07-27 17:30 +0200
      Re: [PATCH v8 05/13] iommu/amd: Add function copy_dev_tables() Baoquan He <bhe@redhat.com> - 2017-07-28 06:00 +0200
  [PATCH v8 06/13] iommu/amd: copy old trans table from old kernel Baoquan He <bhe@redhat.com> - 2017-07-21 11:00 +0200
    Re: [PATCH v8 06/13] iommu/amd: copy old trans table from old kernel Joerg Roedel <jroedel@suse.de> - 2017-07-27 17:40 +0200
      Re: [PATCH v8 06/13] iommu/amd: copy old trans table from old kernel Baoquan He <bhe@redhat.com> - 2017-07-28 09:00 +0200
  [PATCH v8 12/13] iommu/amd: Clear out the GV flag when handle deferred domain attach Baoquan He <bhe@redhat.com> - 2017-07-21 11:10 +0200
  [PATCH v8 07/13] iommu/amd: Do sanity check for irq remap of old dev table entry Baoquan He <bhe@redhat.com> - 2017-07-21 11:10 +0200
  [PATCH v8 11/13] iommu/amd: Don't copy GCR3 table root pointer Baoquan He <bhe@redhat.com> - 2017-07-21 11:10 +0200
    Re: [PATCH v8 11/13] iommu/amd: Don't copy GCR3 table root pointer Baoquan He <bhe@redhat.com> - 2017-07-24 02:00 +0200
    Re: [PATCH v8 11/13] iommu/amd: Don't copy GCR3 table root pointer Joerg Roedel <jroedel@suse.de> - 2017-07-27 18:00 +0200
      Re: [PATCH v8 11/13] iommu/amd: Don't copy GCR3 table root pointer Baoquan He <bhe@redhat.com> - 2017-07-28 11:10 +0200
  [PATCH v8 09/13] iommu/amd: Use is_attach_deferred call-back Baoquan He <bhe@redhat.com> - 2017-07-21 11:10 +0200
    Re: [PATCH v8 09/13] iommu/amd: Use is_attach_deferred call-back Joerg Roedel <jroedel@suse.de> - 2017-07-27 18:00 +0200
      Re: [PATCH v8 09/13] iommu/amd: Use is_attach_deferred call-back Baoquan He <bhe@redhat.com> - 2017-07-28 06:10 +0200
  [PATCH v8 13/13] iommu/amd: Disable iommu only if amd_iommu=off is specified Baoquan He <bhe@redhat.com> - 2017-07-21 11:10 +0200
    Re: [PATCH v8 13/13] iommu/amd: Disable iommu only if amd_iommu=off  is specified Joerg Roedel <jroedel@suse.de> - 2017-07-27 18:00 +0200
      Re: [PATCH v8 13/13] iommu/amd: Disable iommu only if amd_iommu=off  is specified Baoquan He <bhe@redhat.com> - 2017-07-28 11:10 +0200

csiph-web