Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1698596
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/3] staging: ccree: Convert to devm_ioremap_resource for map, unmap |
| Date | 2017-07-28 10:50 +0200 |
| Message-ID | <u8985-1mx-11@gated-at.bofh.it> (permalink) |
| References | <u7RXz-7d4-5@gated-at.bofh.it> <u7RXz-7d4-7@gated-at.bofh.it> <u7RXz-7d4-3@gated-at.bofh.it> <u7WXg-1XP-5@gated-at.bofh.it> <u854t-7lm-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jul 28, 2017 at 09:59:41AM +0530, Suniel Mahesh wrote:
> On Friday 28 July 2017 01:18 AM, Dan Carpenter wrote:
> > On Thu, Jul 27, 2017 at 05:27:33PM +0300, Gilad Ben-Yossef wrote:
> >> + new_drvdata->cc_base = devm_ioremap_resource(&plat_dev->dev,
> >> + req_mem_cc_regs);
> >> + if (IS_ERR(new_drvdata->cc_base)) {
> >> + rc = PTR_ERR(new_drvdata->cc_base);
> >> goto init_cc_res_err;
> > ^^^^^^^^^^^^^^^^^^^^
> > (This code was in the original and not introduced by the patch.)
>
> Hi Dan, the above lines of code were not in the original except
> "goto init_cc_res_err;" which was doing the error handling at different
> places.
>
Yes, yes. I wasn't commenting on the patch just the existing code.
The patch is fine.
regards,
dan carpenter
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/3] staging: ccree: Convert to devm_ioremap_resource for map, unmap Gilad Ben-Yossef <gilad@benyossef.com> - 2017-07-27 16:30 +0200
Re: [PATCH 2/3] staging: ccree: Convert to devm_ioremap_resource for map, unmap Dan Carpenter <dan.carpenter@oracle.com> - 2017-07-27 21:50 +0200
Re: [PATCH 2/3] staging: ccree: Convert to devm_ioremap_resource for map, unmap Suniel Mahesh <sunil.m@techveda.org> - 2017-07-28 06:30 +0200
Re: [PATCH 2/3] staging: ccree: Convert to devm_ioremap_resource for map, unmap Dan Carpenter <dan.carpenter@oracle.com> - 2017-07-28 10:50 +0200
Re: [PATCH 2/3] staging: ccree: Convert to devm_ioremap_resource for map, unmap Gilad Ben-Yossef <gilad@benyossef.com> - 2017-07-30 18:20 +0200
csiph-web