Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1698546

Re: [PATCH V8 1/3] powernv: powercap: Add support for powercap framework

Show all headers | View raw

Cyril Bur <cyrilbur@gmail.com> writes:
> This is more for MPE and Stewart:
> If there is some mutual exclusion that needs to happen, it should be
> done in skiboot. We've had problems in the past with double entering
> skiboot and hard to interpret errors ending up in userspace, this
> solves that but it seems more like a coverup than an actual solution.

Yeah, I'd like us to be in a position where we don't force mutual
exclusion on such things out to the OS.

The real issue this papers over is the async token stuff you're
reworking. There's that, plus for this specific thing, you *could* go
and set a differnt powercap 180 times concurrently and we should do the
right thing in skiboot... but then you're sitting in skiboot rather than
sitting in linux being able to go run some other task on the thread.

-- 
Stewart Smith
OPAL Architect, IBM.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V8 1/3] powernv: powercap: Add support for powercap framework Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2017-07-26 07:10 +0200
  Re: [PATCH V8 1/3] powernv: powercap: Add support for powercap  framework Cyril Bur <cyrilbur@gmail.com> - 2017-07-28 03:40 +0200
    Re: [PATCH V8 1/3] powernv: powercap: Add support for powercap  framework Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2017-07-28 06:10 +0200
    Re: [PATCH V8 1/3] powernv: powercap: Add support for powercap framework Stewart Smith <stewart@linux.vnet.ibm.com> - 2017-07-28 09:20 +0200

csiph-web