Re: [PATCH V1 03/12] spmi: pmic-arb: clean up pmic_arb_find_apid function

From	kgunda@codeaurora.org
Newsgroups	linux.kernel
Subject	Re: [PATCH V1 03/12] spmi: pmic-arb: clean up pmic_arb_find_apid function
Date	2017-07-28 07:40 +0200
Message-ID	<u86ae-7YD-9@gated-at.bofh.it> (permalink)
References	<u5edY-46l-13@gated-at.bofh.it> <u5edZ-46l-33@gated-at.bofh.it> <u826B-5lO-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2017-07-28 06:48, Stephen Boyd wrote:
> On 07/20, Kiran Gunda wrote:
>> Clean up the pmic_arb_find_apid() by using the local
>> variables to improve the code readability.
>> 
>> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
>> ---
> 
> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
> 
> One nit below:
> 
>>  			break;
>> 
>>  		regval = readl_relaxed(pmic_arb->cnfg +
>> -				      SPMI_OWNERSHIP_TABLE_REG(apid));
>> -		pmic_arb->apid_data[apid].owner =
>> -					SPMI_OWNERSHIP_PERIPH2OWNER(regval);
>> +					SPMI_OWNERSHIP_TABLE_REG(apid));
> 
> This should be 7 spaces and not a tab? Originally looks like it
> was 6 spaces
Will fix it and send the next patch.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V1 03/12] spmi: pmic-arb: clean up pmic_arb_find_apid function Kiran Gunda <kgunda@codeaurora.org> - 2017-07-20 09:40 +0200
  Re: [PATCH V1 03/12] spmi: pmic-arb: clean up pmic_arb_find_apid  function Stephen Boyd <sboyd@codeaurora.org> - 2017-07-28 03:20 +0200
    Re: [PATCH V1 03/12] spmi: pmic-arb: clean up pmic_arb_find_apid  function kgunda@codeaurora.org - 2017-07-28 07:40 +0200

csiph-web